[linker][x86_64] page fault crash happens when calling lk_init_level() in lk_main() about lk

[travisg]

Ah hah. Now I understand why that code was in there before. I couldn't figure out what the fix was for when it was added a while back on x86-64. For whatever reason it only affects x86-64, arm64 doesn't have this problem.

I'll take a look at it tomorrow. I really dont want the special case ARCH_X86_64 thing polluting the code, so have to find a better solution for it.

[bingzhux]

Travis,
Can you please help to check the output file "lk/build-pc-x86-64-test/lk.elf.sym.sorted" in your build machine to see if this alignment issue exists or not?

I found there is a link script to make init structure with 8-byte alignment, but have no idea why it does work.
https://github.com/travisg/lk/blob/master/top/init.ld
https://github.com/travisg/lk/blob/master/app/app.ld
https://github.com/travisg/lk/blob/master/dev/drivers.ld
https://github.com/travisg/lk/blob/master/dev/devices.ld

Besides, it seems that we need to figure out a solution to get it fixed by covering both 32bit and 64bit (for x86, arm or other ARCHs).

Currently, my solution is just to make them aligned with 4-bytes.
see my patch here, please let me know if it is ok or not.
bingzhux@012231b

[travisg]

I think this is fixed now. Going to close now, re-open if it's still broken on your end.

[bingzhux]

yes, I cannot reproduce this issue any more.