Coder Social home page Coder Social logo

Comments (7)

gilv avatar gilv commented on July 20, 2024

to clean data for failed jobs we can always do

try:
   pw.map(func, ...)
   results = pw.get_result()
   print("Execution completed")
except Exception as e:
  print (e)
finally:    
  pw.clean()

But this need to be done automatically

from lithops.

JosepSampe avatar JosepSampe commented on July 20, 2024

@gilv This is fixed in #122, as long as you have data_cleaner = True in config.
https://github.com/pywren/pywren-ibm-cloud/blob/master/pywren_ibm_cloud/wren.py#L318

from lithops.

gilv avatar gilv commented on July 20, 2024

@JosepSampe data_cleaner = True will delete all data from successfull and failed jobs.. I wonder if cleaning partial results of failed jobs is the same as cleaning data from successfull jobs. Is there somethign different we can do with data from failed and successfull jobs?
I think to generate graphs requires data cleaner to be false, right? this is why we have default data_cleaner = false. Am i correct?

from lithops.

JosepSampe avatar JosepSampe commented on July 20, 2024

@gilv I don't know why default data_cleaner = false... In fact it can be true since plots can be created anyway. Only in that case you use rabbitmq you need data_cleaner = False, becasue then you need to keep statuses in COS in order to print plots, since statuses are not downloaded trough rabbitmq. But rabbitmq is not the default usage of PyWren, so I think we can move default data_cleaner = True.

Also, I think there is nothing different we can do with failed jobs. PyWren raises the exception and then data_cleaner can be automatically executed.

from lithops.

gilv avatar gilv commented on July 20, 2024

@JosepSampe so should we make the default data_cleaner=True ?

from lithops.

JosepSampe avatar JosepSampe commented on July 20, 2024

@gilv I think so

from lithops.

JosepSampe avatar JosepSampe commented on July 20, 2024

@gilv I think this one can be already close with #233 . Now the data_cleaner() is always executed from any failed job

from lithops.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.