Coder Social home page Coder Social logo

Comments (6)

provinzkraut avatar provinzkraut commented on June 19, 2024 1

The PR was merged into develop. GitHub does not consider this merged as it's not the default branch. We do have a workflow that's supposed to close these issues, but it currently has an issue when the PR originates from a fork (see the failing workflow here).

from litestar.

provinzkraut avatar provinzkraut commented on June 19, 2024 1

Closed in #3064.

from litestar.

provinzkraut avatar provinzkraut commented on June 19, 2024

Sounds good to me. It seems like you already figured out what changes need to be made here. Do you want to open a PR for this?

from litestar.

floxay avatar floxay commented on June 19, 2024

I have just realized that by simply doing url.path the query parameters will be gone as well.

So, for example;
Validation failed for GET http://127.0.0.1:8000/?q=s
would become
Validation failed for GET /
instead of the originally mentioned
Validation failed for GET /?q=s

It makes sense for the 'feature request' as it really is just the path that's there but my example was incorrect. (I have now edited it in the original post)

from litestar.

floxay avatar floxay commented on June 19, 2024

Shouldn't have this auto-closed when #3064 got merged? Is it some Github feature/behavior I am unaware of or is it still open on purpose?

from litestar.

github-actions avatar github-actions commented on June 19, 2024

A fix for this issue has been released in v2.7.0

from litestar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.