Move `requests` to `testing` extra about litestar

[Goldziher]

If you're going to implement it, I'll keep it open.

[Goldziher]

Hi @Bobronium. This will be a breaking change because the test client etc. are returned from the bottom level __init__ at present.

[Bobronium]

@Goldziher, indeed. How big of an issue is that? Is that the only issue you see in the proposal?

[Goldziher]

Well it is. I understand if you want to make it an extra to remove it from the production code - that's fine. But a breaking change is a problem. Is there a way to add it to extra and have it as the default install path? Otherwise I think this is a no go TBH. The other issue is documentation - it needs to be made clear that this is required for the testing component etc.

[Bobronium]

We can overcome this by declaring __getattr__ in init.py (PEP 562) to make smooth transition then:
cat starlight/__init__.py

...

def __getattr__(name: str):
    if name not in {"TestClient", "create_test_client", "create_test_request"}:
        raise AttributeError()
    import warnings
    warnings.warn(f"Importing {name} from {__package__} is deprecated, use `from startlite.testing import {name}` instead", DeprecationWarning, stacklevel=2)
    from . import testing
    attr = globals()[name] = getattr(testing, name)
    return attr

python -c "from starlite import TestClient; print(TestClient)"

<string>:1: DeprecationWarning: Importing TestClient from starlite is deprecated, use `from startlite.testing impory TestClient` instead
<class 'starlite.testing.TestClient'>

[Goldziher]

go ahead and make a PR if it's not a big issue. @peterschutt and myself will check it out - I am apprehensive about breaking code for users TBH, but i am will to test it first.

Thanks for contributing!

[Goldziher]

So, should I close this issue?

[Bobronium]

If you don't consider this an issue, sure.

I'm still positive on implementing this. Just haven't have time to do it yet.