FR: Reconnect when the link is disconnected. about lita-slack

[josqu4red]

Had the case a few times on my instance, just after a team_migration_started event.

[josacar]

Maybe the simplest thing is shutdown the robot like this:

websocket.on(:close) { log.info("Disconnected from Slack."); robot.shut_down }

[jimmycuadra]

Agreed. Reconnection should be handled by a process manager. What lita-slack should do is make sure the process shuts down correctly when the connection is lost.

[ikeji]

Thanks a lot!!

[jimmycuadra]

You're welcome! This was released in gem version 1.1.0.

[josacar]

Thanks!

[reidblomquist]

@jimmycuadra why is it your opinion that this should be handled by a process manager instead of making this process bulletproof? as far as I know the IRC adapter can auto reconnect...

[jimmycuadra]

If someone wants to implement auto-reconnection, I'd be happy to take a PR. See litaio/lita-hipchat#20 for a discussion on this topic in the HipChat adapter where people convinced me the plugin should do it.

[reidblomquist]

Awesome, thanks for the input @jimmycuadra - will read over your comments there and work on putting together a PR.