login failed when pass PASSWORD using FILE__PASSWORD about docker-code-server

[github-actions]

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

[aptalca]

Looks like your password files have trailing newlines.

Create them with printf as described in the docker secrets docs so they don't have the trailing newline

[NigelBoxing]

Looks like your password files have trailing newlines.

Create them with printf as described in the docker secrets docs so they don't have the trailing newline

Thanks a lot. I try printf my-password > password.txt and docker-compose up again. To my surprise, it works well.
but i still don't know that why code-server could not set the password properly when the user fill password to password.txt via vim or echo xxx > password.txt
Is it a bug? the code-server forgets to trim the password.

[aptalca]

Is it a bug? the code-server forgets to trim the password.

You can report that upstream

But as you can see, the SUDO_PASSWORD, which is set by our image in bash, is failing because the trailing newline breaks our bash code and results in the error:

setting sudo password using SUDO_PASSWORD env var
Enter new UNIX password: Retype new UNIX password: Sorry, passwords do not match
passwd: Authentication token manipulation error
passwd: password unchanged

[NigelBoxing]

Is it a bug? the code-server forgets to trim the password.

You can report that upstream

But as you can see, the SUDO_PASSWORD, which is set by our image in bash, is failing because the trailing newline breaks our bash code and results in the error:

setting sudo password using SUDO_PASSWORD env var
Enter new UNIX password: Retype new UNIX password: Sorry, passwords do not match
passwd: Authentication token manipulation error
passwd: password unchanged

Indeed, you are right.
Anyway, thanks a lot.