Coder Social home page Coder Social logo

Comments (4)

github-actions avatar github-actions commented on June 24, 2024

Thanks for opening your first issue here! Be sure to follow the issue template!

from docker-code-server.

aptalca avatar aptalca commented on June 24, 2024

8443 is the upstream default port, not something we arbitrarily chose.

Reguardless if the traffic is put behind a reverse proxy, there needes the be the option for us to change the port the service runs on without having to put it behind an additional proxy.
I don't follow this part. When you put it behind a reverse proxy, your proxy service is accessible at 80/443, and it connects to code-server on its port 8443 on the backend. No need to change any ports

from docker-code-server.

simeononsecurity avatar simeononsecurity commented on June 24, 2024

Lets say, idk I'm an crazy homelaber or enterprise who runs an IPS/IDS. Firewalls don't like seeing HTTP traffic on HTTPS ports.
A reverse proxy isn't a solution to a port problem when the port problem can be argueably easily fixed. A reverse proxy only adds security relative to exposing your system unencrypted to the public internet. Traffic between the proxy and the system is still unencrypted. The system is still insecure. You've just added a "secure" gateway to access it publically. It still doesn't make any sense to have HTTP traffic running on 8443.

Not to claim you have security in mind when making the images. But Linux, an already highly secure operating system, and the people who work with it expect things to work certain ways following certain practices. The ones I'm most familiar with being the ISO27xxx series.

I get it from the code maintainer POV, you just don't see it as required. From my POV, why have something work purposely against best practices and what the people using your images expect?

At the very least, it's an issue of principle. At most, it causes many headaches for administrators who want something implemented properly to all best practices.

from docker-code-server.

aptalca avatar aptalca commented on June 24, 2024

Go wild: https://blog.linuxserver.io/2019/09/14/customizing-our-containers/

from docker-code-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.