Comments (6)
I think it just simplifies the flow.
from coachproxy-os.
Thinking about this a bit more, and since this change adds no tangible benefit, I wonder if it makes more sense to start from scratch on the flows to see what other optimizations can be made... my new Canbus decoder provides an easier way to get at some of the RVC data, which could also simplify things.
from coachproxy-os.
Sure, that makes sense. I looked at your new code, it does look simpler and cleaner than the old perl code, but now I have to come up to speed on Ruby... So, are you running a separate RPi with the new code to build and test? Wondering if I can start substituting Ruby for Perl modules on the same RPI.
from coachproxy-os.
I am running a separate RPi for development efforts, but you could easily run both on the same RPi. I think Python would be ideal as it's more widely used than Ruby, but I'm not nearly as proficient in it so I went with Ruby. Feel free to throw out other ideas... I just really wanted to ditch Perl :-)
from coachproxy-os.
I've got several changes & enhancements, but don't know if you want to throw those in to legacy while working on the Ruby platform. 1. I needed to merge my batteries on command, so I created that. 2. I don't like Temps displayed in tenths, there's no way the sensors are that good anyway, so I removed that. 3. I implemented Pushover where you left a blank space for it. 4. Added inverter temperatures to monitoring after one of my neighbors experienced bad fans. 5. added battery bay temp
from coachproxy-os.
I also set up a battery merge for my personal use.
I think 1, 4, and 5 are probably specific to certain coach models and years. Do you have it set up so those only show up in the UI by request or by year/model? If not, I could help get that part done since that code can be tricky. Knowing what features exist on each model and year has been one of the hardest things to figure out though. For 2, I like the tenths so I can at least see if/when the thermostat might be ready to turn on/off and if the temp reading is actually changing (e.g. on really hot days when the AC is having a hard time keeping up). We could make it a configurable option. For 3, we could include Pushover for everyone along with a little text explaining what it is. I originally took it out since I figured it wouldn't interest 99% of users and had the potential to confuse people.
As for whether or not to include these changes in legacy or not, my preference is to try to forge forward with something new (and hopefully easier to modify / maintain) unless some of these would have a big impact/win for existing users.
from coachproxy-os.
Related Issues (20)
- flows_coachproxy-template.json mis formatted. HOT 5
- Add 2014 Open Road 36LA
- Question HOT 1
- RFE: Instructions on extending for new models HOT 1
- Update OS to Raspbian Buster (2019) instead of Raspbian Stretch (2018). HOT 2
- Enhance Awning Capabilities
- Provide enhancements for Vanleigh Fifth Wheels
- Allow the toggling of the front heat pump unit
- Provide base models for Vanleigh Vilano and Beacons for 2018-2020
- Menu is always open by default
- Eliminate overlayfs and read-only file system.
- New version of HA-Bridge for Alexa HOT 4
- KIB v-bus support
- Update version of ngrok HOT 2
- Eliminate requirement of having an external WiFi adapter HOT 1
- Email notifications don't work HOT 4
- UI flow not being created HOT 6
- Setting coach configuration through UI doesn't work HOT 1
- Provide instructions for configuring SMTP server settings
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coachproxy-os.