Comments (6)
(I think that) the only occurrence is in complib_init function which returns void ;-(
complin_init function API could be changed to return status rather than void and fix internal uses of this function to exit on bad status but that breaks out of tree uses.
A new function (complib_init_v2) that returns status could easily be added and change all internal uses to that as well as deprecate the old function but old function wouldn't be removed for several releases.
To me latter approach is least bad or do you see other/better approach ?
from opensm.
Besides complib_init
, __hca_sim_get_num_cas
calls exit()
which is used by osm_vendor_get_all_port_attr
, osm_vendor_get_guid_ca_and_port
, and osm_vendor_get_guid_by_ca_and_port
.
The latter approach sound better to me as well.
from opensm.
Implemented patch to deprecate complib_init and add complib_init_v2. Sent to you for review.
The other routines you mentioned are in libvendor. I will work on those tomorrow in a separate patch.
from opensm.
Fixes are pretty simple for libvendor/osm_vendor_mlx_hca_sim.c and libvendor/osm_vendor_mlx_sim.c but not sure if it's worth doing this as ibutils (which contains ibmgtsim) has been deprecated for quite some time.
from opensm.
Just sent patch with the libvendor changes.
from opensm.
Reviewed and test-build both patches. They look good to me.
from opensm.
Related Issues (15)
- Question about the release .tar.gz files HOT 2
- opensm has errors from man HOT 3
- non-POSIX variable name in Makefile.am
- Remove structure packing where not needed HOT 4
- libopensm version HOT 5
- OpenSM: Add information about limitations HOT 4
- opensm high load issue
- Opensm 3.3.21 Crash on debian systems
- partitions.conf uses magic values for rate and mtu which are not documented HOT 1
- subnet_prefix not honored with recent kernels HOT 6
- New release HOT 2
- git tags are not consistent HOT 2
- Unresolved symbols in shared libraries HOT 13
- Please provide systemd service files HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opensm.