Comments (9)
Have you tried the latest code? This should have been fixed by #267 which came after 2.0-rc5.
from nvme-stas.
BTW, this dependency is only needed to run the tests. We added required: false
to the dependency, which should solve this issue.
from nvme-stas.
I did, it's not fatal anymore but the fallback doesn't work either.
from nvme-stas.
Oh, I see, the meson fallback
option is used to build a subproject in case of an missing dependency. That's obviously disabled within buildsystem env, forbidding internet access or embedding libraries in general. In any case the python3-libnvme
pkg-config module requirement is an issue.
from nvme-stas.
Are you running the unit tests as part of the buildsystem? If you are not running the tests, then it's not an issue.
The tests depend on python3-libnvme
being installed. Or maybe the issue is that meson cannot find Python packages because they don't usually come with a .pc
file. Is that the issue?
There's another way I can check for the presence of python3-libnvme
, but it's not going to be a meson approach, and if the library is missing the tests will be skipped.
I'm open to suggestions.
from nvme-stas.
Fixed by #275
@tbzatek - Please check that the above pull request fixes the issue. Thanks.
from nvme-stas.
Nope, that made things actually worse. The test
subdir and its meson.build
file suggests that this target is always enabled, failing the basic build:
$ meson --wrap-mode=nodownload -Dman=true -Dhtml=true .build
The Meson build system
Version: 0.63.2
Source dir: /tmp/nvme-stas
Build dir: /tmp/nvme-stas/.build
Build type: native build
Project name: nvme-stas
Project version: 2.0
Host machine cpu family: x86_64
Host machine cpu: x86_64
Program python3 (lxml) found: YES (/usr/bin/python3) modules: lxml
Configuring nvme-stas.spec using configuration
Configuring .coveragerc using configuration
Configuring coverage.sh using configuration
Configuring defs.py using configuration
Configuring __init__.py using configuration
Configuring org.nvmexpress.staf.conf using configuration
Configuring org.nvmexpress.stac.conf using configuration
Configuring stafd.service using configuration
Configuring stacd.service using configuration
Configuring stas-config.target using configuration
test/meson.build:13:0: ERROR: Automatic wrap-based subproject downloading is disabled
I guess the --wrap-mode=nodownload
meson argument should be crucial for a final test before making a release. It's a default of many distribution buildsystems. We don't need to run unit tests during the build. For the record, this is how the default Fedora meson command expansion looks like:
/usr/bin/meson --buildtype=plain --prefix=/usr --libdir=/usr/lib64 --libexecdir=/usr/libexec --bindir=/usr/bin --sbindir=/usr/sbin --includedir=/usr/include --datadir=/usr/share --mandir=/usr/share/man --infodir=/usr/share/info --localedir=/usr/share/locale --sysconfdir=/etc --localstatedir=/var --sharedstatedir=/var/lib --wrap-mode=nodownload --auto-features=enabled . redhat-linux-build -Dman=true -Dhtml=true
(we've only added -Dman=true -Dhtml=true
there)
from nvme-stas.
Hi @tbzatek - Thanks for mentioning the --wrap-mode=
option. With that I was able to reproduce the problem you mentioned. Hopefully this latest pull request will fix the issue once and for all.
Fixed by #279
from nvme-stas.
Tested git master, everything works without any issue. Thanks!
from nvme-stas.
Related Issues (20)
- Use auto-generated hostnqn as a fallback HOT 7
- IndexError: list index out of range
- nvme-stas discovers pcie nvme devices? HOT 2
- nvme: failed to disconnect, error 2 HOT 6
- Unable to save last known config: [Errno 2] No such file or directory: '/run/stafd/last-known-config.pickle' HOT 1
- All the connections lost after storage upgrade because the nvme-stas stopped reconnecting after 60 times HOT 2
- Trim whitespace in trsvcid and traddr HOT 1
- Create/Delete operations get executed in the wrong order HOT 1
- nvme0 - Registration error. Result:0x0000, Status:0x4002 - Invalid Field in Command HOT 7
- make rpm fails on fedora-36 HOT 4
- nvme-stas needs additional config options to apply in-band auth settings HOT 8
- Bad whatis entries for several man pages HOT 4
- test_new: gi.repository.GLib.GError: g-io-error-quark: Could not connect: No such file or directory (1) HOT 6
- Grammar mistake "allows to do" HOT 1
- How to run test suite against the installed project HOT 3
- nvme-stas does not disconnect PDC on receipt of mDNS goodbye packet HOT 4
- Scaling issues with nvme-stas HOT 8
- Test Udev (legacy test G6) fails (when interface has multiple IPv6 addresses) HOT 2
- Udev test issues with esoteric network interfaces HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nvme-stas.