0 - Implement matches text about spotifube

[djalmaaraujo]

@linusg There are some crazy approaches, like starting a dev server inside of electron. Just being explicit so we don't endup doing crazy things. That's why we should use PR's ;)

thanks for asking

[djalmaaraujo]

@sdhutchins I think I understand what you are saying. Sorry for the confusion. I prefer and it's recommended by react people to extract components into smaller components. Right now the initial screen is doing too much. One of the refactorings I will do this week is moving code into smaller components or moving "main" stuff to "main".

[djalmaaraujo]

@sdhutchins For example, this image:

1 - Input would be a separated component
2 - The button is another
3 - The message is another
4 - The "PageInput" for example, or "Main" would be a component using all 3 before.

[djalmaaraujo]

A note for communicating with the Electron and the front-end. We should always use ipcMain and ipcRender for communication between these to layers.

[linusg]

We should always use ipcMain and ipcRender for communication between these to layers.

Just being into electron for some days, what would be the alternative? At least the docs explicitely state using these.

[linusg]

Anyone except me still working on anything? 🤔

[sdhutchins]

@linusg Yeah, hopefully, I'll open a PR today or tomorrow.

[sdhutchins]

Is there a preference for placement of the "download playlist" code? Would it be better to place that with the playlist input code because so far I'm doing it that way? @linusg @djalmaaraujo

[djalmaaraujo]

@sdhutchins What do you mean? I would have a button, firing a ipcMain event to the MAIN of electron and handle the download there.

[djalmaaraujo]

@linusg @sdhutchins I will spend some time this week on this project. Expect some Pr's

[sdhutchins]

@linusg @djalmaaraujo right now the different components of the app are split in the renderer folder and I was trying to figure out if that was a desire or not? If not, I can go ahead and open another PR with those additions. I'm just curious if there are style related desires for what things look like for the app outside of having a main and renderer folder.

[djalmaaraujo]

@sdhutchins I am not sure if you understand the concept of the main / renderer.

main = imagine like backend, no UI
renderer = the front-end of the app, react, UI interactions, DOM, etc.

Components will always be inside the renderer.

👍

[sdhutchins]

@sdhutchins I am not sure if you understand the concept of the main / renderer.

main = imagine like backend, no UI
renderer = the front-end of the app, react, UI interactions, DOM, etc.

Components will always be inside the renderer.

I understand main vs renderer. Not what I'm asking.

Again,

right now the different components of the app are split in the renderer folder and I was trying to figure out if that was a desire or not? If not, I can go ahead and open another PR with those additions. I'm just curious if there are style related desires for what things look like for the app outside of having a main and renderer folder.

Meaning other than the required style design of having main and renderer...are their style desires for components being split or would it be ok to turn playlist-input into playlist-download with some edits to that component. It wouldn't be hard to add more to it to make that component take input as well as handle downloading.

[sdhutchins]

I already have that written, but I wasn't sure if @djalmaaraujo @linusg you two wanted the code to be simpler or not or had a preference on that either way.

[sdhutchins]

For example, here is our repo.

My question was just asking about what style @linusg was going for with components and how he'd feel about me turning playlist-input into playlist-download instead of creating a new folder and index.js for a download class or function.

[sdhutchins]

If I'm not being clear, I apologize. I understand the necessary structure of the app. I'm asking specifically about what's written for playlist-input and if there was a vision for how that would transform or maybe not.

[sdhutchins]

@sdhutchins I think I understand what you are saying. Sorry for the confusion. I prefer and it's recommended by react people to extract components into smaller components. Right now the initial screen is doing too much. One of the refactorings I will do this week is moving code into smaller components or moving "main" stuff to "main".

Thanks for that. I just wanted to keep those kinds of things in mind as I haven't created an electron app before, and I know it's pretty crucial to try to adhere to common practices in other programming languages even if they aren't written.

[sdhutchins]

Thanks! @djalmaaraujo That's very helpful. I'll try to develop in that way.