Coder Social home page Coder Social logo

Comments (6)

timyitong avatar timyitong commented on June 10, 2024

This PR is one step towards this issue: #126
as we are easing the input format assumption for the simple linear model driver .

from photon-ml.

fastier-li avatar fastier-li commented on June 10, 2024

@XianXing - is this still an issue we need to look at? Please let me know - we might work on it soon.

from photon-ml.

XianXing avatar XianXing commented on June 10, 2024

I think recent refactoring (client/core/lib) on Photon should be related to the idea proposed here, basically we'd like to make sure Photon is not restricted to Avro serialized/formatted data.

But you guys have more context than me now, so please feel free to close this issue once the client/core/lib refactoring is done (is it done already?).

from photon-ml.

fastier-li avatar fastier-li commented on June 10, 2024

from photon-ml.

fastier-li avatar fastier-li commented on June 10, 2024

The "master plan" is to provide a library of data readers for various format that would all feed GameEstimator.fit with DataFrames and ancillary data structures. This is already exemplified by [AvroDataReader](https://github.com/linkedin/photon-ml/blob/8702fea9a436d4979a3e672fe20ae30e32078f43/photon-client/src/main/scala/com/linkedin/photon/ml/data/AvroDataReader.scala).

I'm going improve on the recent client refactoring by isolating AvroDataReader in an avro package, and colocate in that package the model writer too. We can then have parallel modules for parquet ... and others.

from photon-ml.

ashelkovnykov avatar ashelkovnykov commented on June 10, 2024

While we don't have support for Parquet or LIBSVM data in the client code, sufficient decoupling has been done. For a while now, the input to the GameEstimator has been a DataFrame with features stored as Vector objects.

For that reason, I am going to close this issue and separate ones can be opened for adding specific kinds of readers derived from DataReader.

from photon-ml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.