Comments (6)
Hi @lindelius, I have some questions about this issue.
- Do we need to implement this feature for this package?
- Can we include the
ES
libraries to support this feature?
Thanks.
from php-jwt.
Hi @peter279k,
Thank you for showing interest in the library.
The ideal contribution would implement the missing algorithms in a similar fashion to https://github.com/lcobucci/jwt and https://github.com/web-token/jwt-framework, and without requiring any external libraries or creating any additional classes.
from php-jwt.
Hi @lindelius, thank you for your reply.
After looking at the repos that you mention, I think they use the additional ECC
package to complete this featutre.
The lcobucci/jwt uses the phpecc library.
And the web-token/jwt-framework uses the sub repo in this main repo.
You should check that.
from php-jwt.
@peter279k, Thank you for taking the time to dig around.
I have done some thinking and while I'm still against adding any external libraries (extensions would be OK) I did end up reworking the algorithm support to make it more extendable. The updated code is in the extendable-algorithm-support
branch, and if you have the time I would appreciate your input.
I haven't started on any EC implementations, but the rework should make adding this easier. The idea is to add the necessary traits, and, if necessary, additional classes, as well.
from php-jwt.
@lindelius, thank you for your reply.
After looking at the extendable-algorithm-support
branch, it seems that you want to create the ES256
, ES384
and ES512
classes without any php-ecc
package/dependencies.
I think it's fine to use this approach you mention to complete this feature.
But I think we need to keep this ES
functionality simple and lightweight.
I will refer that branch and create the PR for this issue and let you review that.
Thanks :).
from php-jwt.
@lindelius, I also refer this psecio/jwt
repo to implement this ES
algorithm support.
Please check that, thanks.
from php-jwt.
Related Issues (9)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from php-jwt.