Coder Social home page Coder Social logo

Comments (6)

RomaricMourgues avatar RomaricMourgues commented on September 14, 2024

Fixed

  • 1, 6 and 11 are fixed on next PR

Need design rethink

  • 5 and 9 (related to access management clarity)

from twake.

RomaricMourgues avatar RomaricMourgues commented on September 14, 2024

PR status #2774

from twake.

RomaricMourgues avatar RomaricMourgues commented on September 14, 2024

@tprudentova for the access management waiting for me to improve the clarity, let me explain how it works:

  • First we look if we are in the context of a public link, if currently checked element correspond to the public link we stop and return expected access level
  • Then we look at direct access info, for instance current user is specifically indicated as "write" access then we use this information and we don't look anywhere else
  • Then we take the maximum level available of this two:
    • Look up recursively and apply previous points to parent folders if 'inherit' is true and get the maximum level returned
    • If we are member of the company, get the defined access level as member of the company

For root and trash, we have special rules depending on if you are guest or not, and admin or not.


This being said, I think we must change the inherit folder and company part, something as simple as "if inherit is on, then company access cannot be restricted", it means the "company has access" will be shown only if inherit is set to off

I'm thinking about clarifying the fact that direct access on user is in priority to the company/inherit access, still thinking about it now.

Finally, you didn't tried it yet but when linking a folder to a chat tab then it works a bit like public sharing for the logic.

from twake.

tprudentova avatar tprudentova commented on September 14, 2024

@RomaricMourgues okay, I think I got you, thank you!
Maybe (just a suggestion) we could sort the access options in the order of priority? Like, public link on top, them direct access, then inherit, then all members. I'm not sure whether it's a good way to solve this, but it seems more intuitive to consider things at the top of the list more important.
Also, I couldn't find a way to link a folder to a chat... Is this feature not on canary yet or am I just blind? :')

from twake.

RomaricMourgues avatar RomaricMourgues commented on September 14, 2024

To link a folder to a chat open a workspace channel then add a new tab at the top and select "Document" then you'll have it.

Screenshot 2023-03-10 at 10 14 53

from twake.

tprudentova avatar tprudentova commented on September 14, 2024

Ohhhh I see, thank you :)

from twake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.