Comments (6)
Fixed
- 1, 6 and 11 are fixed on next PR
Need design rethink
- 5 and 9 (related to access management clarity)
from twake.
PR status #2774
from twake.
@tprudentova for the access management waiting for me to improve the clarity, let me explain how it works:
- First we look if we are in the context of a public link, if currently checked element correspond to the public link we stop and return expected access level
- Then we look at direct access info, for instance current user is specifically indicated as "write" access then we use this information and we don't look anywhere else
- Then we take the maximum level available of this two:
- Look up recursively and apply previous points to parent folders if 'inherit' is true and get the maximum level returned
- If we are member of the company, get the defined access level as member of the company
For root and trash, we have special rules depending on if you are guest or not, and admin or not.
This being said, I think we must change the inherit folder and company part, something as simple as "if inherit is on, then company access cannot be restricted", it means the "company has access" will be shown only if inherit is set to off
I'm thinking about clarifying the fact that direct access on user is in priority to the company/inherit access, still thinking about it now.
Finally, you didn't tried it yet but when linking a folder to a chat tab then it works a bit like public sharing for the logic.
from twake.
@RomaricMourgues okay, I think I got you, thank you!
Maybe (just a suggestion) we could sort the access options in the order of priority? Like, public link on top, them direct access, then inherit, then all members. I'm not sure whether it's a good way to solve this, but it seems more intuitive to consider things at the top of the list more important.
Also, I couldn't find a way to link a folder to a chat... Is this feature not on canary yet or am I just blind? :')
from twake.
To link a folder to a chat open a workspace channel then add a new tab at the top and select "Document" then you'll have it.
from twake.
Ohhhh I see, thank you :)
from twake.
Related Issues (20)
- plugins add HOT 2
- 📁 Documents - bugs on QA
- 📁 QA Drive issues
- Drive add the "edit with" feature
- Drive on QA
- 📁 TDrive canary bugs HOT 3
- Drive canary some more bugs HOT 1
- [Vacation] Sender still get automatically reply email even if receiver already turn off vacation mode in setting
- All files lost in "document" tab of a channel, web.twake.app server HOT 4
- send mail invitaion with twake version node HOT 2
- Cassandra startup fatal errors
- Plugins Add : repo name must be lowercase
- Will there be support for arm64 images in docker
- connector.api doesnt work anymore
- calling lineshare from twake start.menue in console.twake doesnt reach lineshare functionality
- many, many bugs in your cloud functionality - seems nothing works anymore HOT 1
- Security Issue - Request For Contact Details HOT 4
- Bad label in Twake Drive during upload
- GOOGLE CALENDAR ics file import : "Request Entity too Large" or "Mime type not recognized"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twake.