Pass class and id via shorthand in $ about helix

[lilactown]

This seems specific to the web DOM, so I think this would be a good addition to the helix.dom/$d macro, rather than the helix.core/$.

[SevereOverfl0w]

There's an implementation of this in https://git.sr.ht/~severeoverfl0w/helix-sev

[lilactown]

Very nice! Question:

($d :div.foo.bar {& {:class "baz"}} ,,,)

based on my read of your code as-is, the dynamic prop :class will overwrite the class assoced onto the props map. This is because (helix detail) dynamic props are merged in after macro expansion, in something like:

(react/createElement "div" (merge-props #js {:class "foo bar"} {:class "baz"}) ,,,)

It's not clear to me what the correct behavior is here. what do you think?

[SevereOverfl0w]

@lilactown You're right, that's a limitation right now. It has that limitation because I didn't think it was possible to implement things such that this limitation wouldn't exist. I think there're two behaviours here that make sense:

• Behave like {:class "foo bar" :& {:class "baz"}} would
• Always append the root onto the resulting props, no matter what.

If :&, &, etc. are present, we could wrap the expression such that the classes are appended. If they aren't present, then we do the current implementation?