Coder Social home page Coder Social logo

Comments (16)

lilactown avatar lilactown commented on June 19, 2024

I haven't tested helix in a figwheel project. Can you tell me what version of figwheel you're using? A minimal repro would be very appreciated.

from helix.

amazing-Mantse avatar amazing-Mantse commented on June 19, 2024

I am using figwheel version "0.2.3" and I run it with the following options
--main figwheel.main --compile-opts {:source-map,true} . --build common --repl

from helix.

amazing-Mantse avatar amazing-Mantse commented on June 19, 2024

@Lokeh what do you mean a minimal repro? Do you mean in a new clojure project?

from helix.

amazing-Mantse avatar amazing-Mantse commented on June 19, 2024

@Lokeh here is a minimal hello_world project with figwheel and helix. Still getting the same error.

https://github.com/amazing-Mantse/figwheel-helix

image

from helix.

lilactown avatar lilactown commented on June 19, 2024

Thanks, the minimal example did help.

I created a new branch here: https://github.com/Lokeh/helix/tree/fix-figwheel

There were some additional problems in your minimal repro about "react" that I'm not sure right now how to fix.

Also, unfortunately my current fix in that branch is running into this bug in shadow-cljs thheller/shadow-cljs#638 which prevents me from releasing it at this time.

from helix.

amazing-Mantse avatar amazing-Mantse commented on June 19, 2024

Thank you very much.I will checkout the branch.

from helix.

amazing-Mantse avatar amazing-Mantse commented on June 19, 2024

Hi, I have updated the minimal app (https://github.com/amazing-Mantse/figwheel-helix) and fixed the react issues. From helix.core I get the error bellow:

image

from helix.

lilactown avatar lilactown commented on June 19, 2024

@amazing-Mantse I've merged the fix-figwheel branch with master, which removes that require.

from helix.

amazing-Mantse avatar amazing-Mantse commented on June 19, 2024

Okay, but now I am back to the original error:

I added the dependancy as so :
Lokeh/helix {:git/url "https://github.com/Lokeh/helix" :sha "cfb99f8936aa8d7f71f9759a81a93df9cb4a1772"}} and now I have this error:

image

from helix.

lilactown avatar lilactown commented on June 19, 2024

I've updated the fix-figwheel branch with a few more adjustments.

Here's an example repo using it: https://github.com/Lokeh/fighweel-helix

It's based off of your repo @amazing-Mantse, there was some misconfiguration that I fixed along with updating to the latest git SHA.

from helix.

danieroux avatar danieroux commented on June 19, 2024

Thank you, Figwheel works with this.

The next challenge is advanced compilation which fails with:

ERROR: JSC_LANGUAGE_FEATURE. This language feature is only supported for ECMASCRIPT6 mode or better

I've pushed an example of that to https://github.com/amazing-Mantse/figwheel-helix

And it can be replicated with:

clojure --main cljs.main --compile-opts dev.cljs.edn --compile-opts '{:optimizations :advanced}' --compile

from helix.

lilactown avatar lilactown commented on June 19, 2024

helix's implementation uses several ES6 features - specifically, the class keyword. You'll want to configure your release step to set :language-in :es6 at the least.

from helix.

amazing-Mantse avatar amazing-Mantse commented on June 19, 2024

@Lokeh Thank you very mush for making helix work with Figwheel. We have successfully managed to incorporate it, into our project. And it's looking great. We still have a few hx components, but we are transitioning.

from helix.

lilactown avatar lilactown commented on June 19, 2024

hooray!

from helix.

deoqc avatar deoqc commented on June 19, 2024

Hello!! Thx for the great library @Lokeh

Tried w/:

Lokeh/helix {:git/url "https://github.com/Lokeh/helix"
                       :sha "56ff32df5ca270aac7b63d6ad55adb9c2318f61d"}

but it is throwing Error building classpath. Destination path "helix" already exists and is not an empty directory.

Any ideias/help?

from helix.

lilactown avatar lilactown commented on June 19, 2024

@deoqc this looks like a problem with your local deps. Perhaps try clearing your deps cache? If you keep running into this, please open another issue.

For figwheel usage, I will continue to rebase #26 onto master for the time being until I can merge them. Figwheel users should check that PR to get the latest version compatible.

from helix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.