Coder Social home page Coder Social logo

Comments (6)

darwin avatar darwin commented on July 1, 2024

Found a workaround: binaryage/cljs-react-three-fiber@3838dd6

from helix.

lilactown avatar lilactown commented on July 1, 2024

Wow, nice!

from helix.

lilactown avatar lilactown commented on July 1, 2024

A related thing I've thought about for awhile: emit the actual element object, instead of a call to createElement. Or use our own fn at least that wouldn't pessimistically copy all of the props, similar to reactjs/rfcs#107

from helix.

lilactown avatar lilactown commented on July 1, 2024

@darwin I would take a PR for this. I can also do it myself, if you're not interested

from helix.

darwin avatar darwin commented on July 1, 2024

@Lokeh this is really a small change, it will be better if you did it exactly where you wanted it.

I think calling react/createElement is alwasys fine in dev mode. It contains some defensive dev-time checks and source locations.

We can optimize release mode path to directly call ReactElement, but we must be careful to not break react's assumptions. This would lead to hard-to-debug-in-release-mode-only issues.

from helix.

lilactown avatar lilactown commented on July 1, 2024

Closed with 02b1e20

from helix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.