Comments (7)
I was able to convert all my code to use $
instead of $$
but I had to alter $
macro to be more flexible in dynamic case.
This strategy is following:
- try to determine if props was given as static map
- if not, use dynamic code to test props argument during runtime:
2a) if it is a cljs map use it as props (and translate them using dynamic code path)
2b) else treat it as first child and pass it properly into create element
from helix.
btw. My implementation of $
is just a quick and dirty replacement of helix $
. I do transaltion to native props always, so there is missing original code doing ^:native heuristics. Also maybe there is a potential double evaluation of type or args. This should be written more carefully.
from helix.
@darwin you should be able to avoid doing dynamic testing at runtime by requiring dynamic props be passed to the &
key always. This is the intended reason for introducing the &
spread-props syntax.
($ :bufferGeometry {& geometry-props})
https://github.com/Lokeh/helix/blob/master/docs/creating-elements.md#dynamic-props
from helix.
I'm aware of it. Static code path is preferrable. I just didn't rewrite my old code yet. This dynamic testing is there for correctness. If someone writes (merge props other-props)
insterad of literal map, it must work (maybe a compile-time warning would be nice).
from helix.
At least I believe this merge example cannot be determined statically. The expression result must be tested during runtime to figure out if it is a props map or a first child.
from helix.
I agree that it's not statically analyzable. I disagree that it must work. The $
macro is meant to have specific semantics to prevent having to branch at runtime.
I think adding a warning when goog.DEBUG is true would help detect errors and guide users to correct usage.
from helix.
Closed with 3a6cc3c and ddacbc8
from helix.
Related Issues (20)
- Any good way to make multimethods work as component functions? HOT 8
- gensym / anonymous function syntax breaks fast refresh HOT 2
- Include resources in deps.edn :paths
- $ clj-kondo hook fails to lint & right when component is not a symbol HOT 1
- The $ macro and new JSX transform HOT 14
- `wrap-fx` is public HOT 1
- Wrappers for useTransition, useDeferredValue, etc. HOT 1
- Is it possible to bypass the camel-casing of properties? HOT 7
- Add wrapper around createRef with atom protocols HOT 2
- How to use with uikit? HOT 2
- Running tests in nodejs with jsdom HOT 4
- Companies using Helix HOT 1
- indent metadata on helix.dom macros HOT 3
- Create use-isomorphic-layout-effect HOT 6
- Make self-hosted CLJS compatible HOT 2
- Fix indentation with CIDER HOT 3
- Release request HOT 1
- Warning: React.jsx: Static children should always be an array. You are likely explicitly calling React.jsxs or React.jsxDEV. Use the Babel transform instead. HOT 2
- `helix.dom/tags` removed HOT 2
- defnc taking pre- & post-conditions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helix.