Routing considerations about lilac

[nsthorat]

Some context about how things work right now:

If you spin up a server and go to "/docs" you'll see the OpenAPI spec exposed by the FastAPI server

We use an OpenAPI => TypeScript fetch() compiler from this script which generates all the code in fastapi_client. This is done in the dev server whenever python code is touched (so the typescript hot loader automatically kicks in). What's really nice is we type the FastAPI rest endpoints with pydantic models, which basically act as a very lightweight proto, and it generates the TypeScript interfaces on the other side.

For example:
Python: https://github.com/lilacai/lilac/blob/main/src/router_data_loader.py#L68
Auto-gen'd typescript:

lilac/src/web/fastapi_client/services/DataLoadersService.ts

Line 57 in 203edaa

public static load(

Our RTK Query wrapped endpoint which components actually call:

lilac/src/web/src/store/api_dataset.ts

Line 104 in 203edaa

loadDataset: builder.mutation<

The python server speaks OpenAPI which is really nice because we can generate clients for any language: https://github.com/OpenAPITools/openapi-generator

Is there something that Next.js could give us beyond this?

[HalfdanJ]

Ok i see, makes more sense now. Is /tasks intentionally left outside the api, or just not ported over? That was the one that was fooling me. Same goes with the other routes in server.py.

[nsthorat]

Ah yeah, everything in server.py is a bit old (for the original prototype). We'll clean this up as soon as the new concept builder rough draft is done, we were just keeping that around in case we wanted to look at it. But yeah, everything in server should get prefixed!