Comments (16)
RFP: https://gitlab.com/fdroid/rfp/-/issues/1695
Any updates? @nwingt @williamchong
@linsui @shuvashish76 We certainly do not object to publishing on fdroid, but is there anything extra we need to do code-wise?
We are not familiar with how to publish on fdroid, and what kind of dev resources do we need
from likecoin-app.
RFP: https://gitlab.com/fdroid/rfp/-/issues/1695
Any updates? @nwingt @williamchong
from likecoin-app.
Thanks! How to build the Android app? Is gradle assembleRelease
enough? Firebase and GMS are not FOSS, could you please add a flavor without them? It seems not difficult to patch them out on our side though.
from likecoin-app.
We are using react-native so you might have to yarn build
first, then gradle assembleRelease
should do
However we are using firebase remote-config to fill in some critical config, we need to fill in some production default values first before it would work without firebase
from likecoin-app.
However we are using firebase remote-config to fill in some critical config, we need to fill in some production default values first before it would work without firebase
Will you provide a flavor? Should I fill those values manully?
from likecoin-app.
However we are using firebase remote-config to fill in some critical config, we need to fill in some production default values first before it would work without firebase
Will you provide a flavor? Should I fill those values manully?
We will fill in the default values in a new commit
@nwingt Do you have an idea if firebase-less flavor is do-able in some simple way? If not we will let fdroid patch it
from likecoin-app.
However we are using firebase remote-config to fill in some critical config, we need to fill in some production default values first before it would work without firebase
Will you provide a flavor? Should I fill those values manully?
Please check out the feature/config branch and the README for configuration guide, I have provided necessary config in the .env
file
from likecoin-app.
It's more difficult than I expected to patch nonfree bits out. Could you please help? Thanks!
- Since 8.0.0, play service is optional in react-native-device-info, could you please update it?
- react-native-camera depends on GMS/Firebase, I need to remove it so there is no barcode scanning function.
- react-native-rate depends on play service so I need to remove it.
- Trackers are removed because firebase and fbsdk are nonfree. Sentry is FOSS but I don't know how to keep it.
- Though I can disable remote config, I still need to remove all related lines because I need to remove firebase. Is that possible to make the whole dep optional?
The current metadata is here.
from likecoin-app.
For 1., I have tried to update it, but there is a syntax error when importing the module
For 2, it seems react-native-camera
is not maintained anymore, we should find a replacement without GMS/Firebase
For 3-5, we can deploy a stub for all related services
from likecoin-app.
For 1., I have tried to update it, but there is a syntax error when importing the module
Looks like this is a known issue. react-native-device-info/react-native-device-info#1212
For 2, it seems
react-native-camera
is not maintained anymore, we should find a replacement without GMS/Firebase
Thanks! Before it's replaced (if there is a proper alternative), I can remove the scanning function.
For 3-5, we can deploy a stub for all related services
Thanks!
from likecoin-app.
Finally I make more patches: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11460/diffs I update react-native-device-info/react-native-device-info#1212 and apply the patch suggested here. I thought a proper fix should be updating react native and babel but as a workaround could you please add the patch to patch-package?
I removed react-native-camera. I also removed react-native-iap due to it depends on billing client which is not FOSS.
The apk starts fine but I don't have an account to test it more. If my patches are OK to you I'll do more tests. Then I'll open a PR adding fastlane structure and merge the MR in fdroiddata.
from likecoin-app.
@williamchong @nwingt Are above patches good to you?
from likecoin-app.
@williamchong @nwingt Are above patches good to you?
Sorry for taking so long, we are occupied on a chain upgrade and related releases
for the patch-package
, do you mean we would need to upgrade the device info here and do the patch in this repo too?
from likecoin-app.
You can take those patches or we can just keep them downstream. I want to know if you are OK with such patches.
from likecoin-app.
You can take those patches or we can just keep them downstream. I want to know if you are OK with such patches.
Yes the patches look good to me.
The only important feature removed is qrcode scanning, we will find a replacement for react-native-camera
in later version
from likecoin-app.
Will you merge the feature/config branch in the develop?
from likecoin-app.
Related Issues (20)
- Forever loading after pull to refresh in the reading list view
- Og image in list view for larger screen HOT 2
- Should guard SL feed empty URL HOT 3
- List view distorted issue when changing screen orientation
- Cannot display article title in global list view HOT 1
- The memo page need a "back" or "close" button
- The "redelegate to" screen need a "close" button
- Super Like action was not record correctly
- Last screen of the change password flow redirects to a wrong location HOT 1
- Green-out after relogin HOT 2
- Occasionally missing content jockey name and hence the follow option
- Shows empty error when trying to undelegate invalid LIKE amount
- The language preference does not follow in Authcore account setting HOT 1
- Truncated webpage title
- Lazy load authcore wallet vault to improve app resume time
- Allow updating avatar and display name in app HOT 2
- Number of like clap shown in app is different from button list, which is different from matters HOT 2
- Potantially remove fetchRewardedStatisticsSummary()
- Wrong Word for Translations
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from likecoin-app.