Issue with `doctrine/persistence` v3 about liiptestfixturesbundle

[alexislefebvre]

Please try the last release: https://github.com/liip/LiipTestFixturesBundle/releases/tag/2.4.0

[alexislefebvre]

We may had a compatibility layer in order to call getCache() if it's available, or getCacheDriver() otherwise.

[magnetik]

The new getCache() method in AbstractClassMetadataFactory in now protected (and was public)

[mbabker]

This one's fun.

Based on liip/LiipFunctionalTestBundle#69 the intent is to flush the result cache before loading fixtures, but it's pulling the cache driver from the object manager's metadata factory. Only the ORM has a result cache though. Making things even more inconsistent, the ORM entity manager configures the metadata factory with the metadata cache service, which might not even be the same service as the result cache service. The document managers for MongoDB and PHPCR are also injecting the metadata cache service.

So if the intent is to clear the result cache, as the original PR implies, then there is a long-standing bug that needs to be fixed in the ORMDatabaseTool and it needs to pull the correct cache service from the entity manager's configuration instance and the MongoDBDatabaseTool and PHPCRDatabaseTool classes can have this cache clearing operation removed.

If the intent is to clear the metadata cache, then the way forward looks to be replacing the getMetadataFactory() calls with getConfiguration() (note, that method isn't part of the ObjectManager interface) and fetching the metadata cache service from there.

[MarkPedron]

If the intent is to clear the metadata cache, then the way forward looks to be replacing the getMetadataFactory() calls with getConfiguration() (note, that method isn't part of the ObjectManager interface) and fetching the metadata cache service from there.

I prepared a MR which implements this suggestion - the property $om is annotated as an EntityManager in ORMDatabaseTool, so the fact that getConnection is not part of the ObjectManager interface does not seem to be an issue here.

I do not have much experience with the doctrine caching system, but this PR makes the tests in my projects run.

Edit

This only fixes the issue for ORMDatabaseTool, not MongoDB/PHPCR/ORMSqlite