Coder Social home page Coder Social logo

Comments (4)

SkafteNicki avatar SkafteNicki commented on May 21, 2024 1

I think the proposal solution @jspaezp has implemented is fine. Atleast, it will cover our needs right now. We can always add support for more whenever the case may be.

from torchmetrics.

github-actions avatar github-actions commented on May 21, 2024

Hi! thanks for your contribution!, great first issue!

from torchmetrics.

jspaezp avatar jspaezp commented on May 21, 2024

I can give it a go (I am working on adding spatial metrics and have to deal with this anyway...)

Nonetheless I had a couple of questions...

  1. should it support named arguments and positional matching or only one of those?
  2. should it support different matchings between the reference metric and the implemented metric? (let me know if this makes sense ...)

from torchmetrics.

lucadiliello avatar lucadiliello commented on May 21, 2024

I can give it a go (I am working on adding spatial metrics and have to deal with this anyway...)

Nonetheless I had a couple of questions...

  1. should it support named arguments and positional matching or only one of those?
  2. should it support different matchings between the reference metric and the implemented metric? (let me know if this makes sense ...)

I think it would be better to allow both arguments types. But let's hear the opinion of @Borda and @SkafteNicki. For the second question, I do not know.

from torchmetrics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.