gotype errors in git tip about libvirt-go

[purpleidea]

It seems this only happens in golang 1.9+

[berrange]

The integration_test.go covers passing libvirt.DOMAIN_START_PAUSED to dom.CreateWithFlags, and that compiles & runs fine with go 1.9:

https://travis-ci.org/libvirt/libvirt-go

So I don't see anything that needs fixing in libvirt here. This is simply a tools bug.

[jonathangold]

@purpleidea It appears this issue is caused by gotype's choice to use the source importer for go 1.9 by default. According to https://golang.org/pkg/go/importer/#For

if the compiler argument is "source" [...] if the package API depends on cgo-defined entities, the type checker won't have access to those.

This issue affects more than just gometalinter. Any tool that switched to the source importer for go 1.9 breaks compatibility with projects that use cgo imports.

[purpleidea]

@jonathangold Thanks for tracking this down! Is there an upstream (in golang) issue we can tag or open?

[jonathangold]

@purpleidea Given your familiarity with the go ecosystem, it would be helpful to chat about the appropriate issue(s) to open and/or tag.