Coder Social home page Coder Social logo

Comments (10)

interduo avatar interduo commented on August 28, 2024 1

@thebracket after Your suggestions, I rewrite PR#502 then:

git clone -b patch-32 https://github.com/interduo/LibreQoS LibreQoS;
cd LibreQoS/src/;
./build_rust.sh

Now only compilation warnings/errors in:

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/etclqos_migration.rs:4:17
  |
4 | use toml_edit::{Document, value};
  |                 ^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:226:32
    |
226 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:270:31
    |
270 | fn check_config(cfg_doc: &mut Document, cfg: &mut EtcLqos) {
    |                               ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:175:32
    |
175 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:202:37
    |
202 |   pub fn save(&self, document: &mut Document) -> Result<(), EtcLqosErro...
    |                                     ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/migration.rs:9:16
  |
9 | use toml_edit::Document;
  |                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
  --> lqos_config/src/etc/migration.rs:31:18
   |
31 |         .parse::<Document>()
   |                  ^^^^^^^^

warning: `lqos_config` (lib) generated 7 warnings
   Compiling lqos_sys v0.1.0 (/root/LibreQoS/src/rust/lqos_sys)
   Compiling lqos_queue_tracker v0.1.0 (/root/LibreQoS/src/rust/lqos_queue_tracker)
   Compiling lqos_heimdall v0.1.0 (/root/LibreQoS/src/rust/lqos_heimdall)
   Compiling lqosd v0.1.0 (/root/LibreQoS/src/rust/lqosd)
warning: field `index` is never read
  --> lqosd/src/preflight_checks.rs:49:9
   |
47 | pub struct IpLinkInterface {
   |            --------------- field in this struct
48 |     pub name: String,
49 |     pub index: u32,
   |         ^^^^^
   |
   = note: `IpLinkInterface` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default

warning: `lqosd` (bin "lqosd") generated 1 warning
    Finished `release` profile [optimized] target(s) in 1m 37s
warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/etclqos_migration.rs:4:17
  |
4 | use toml_edit::{Document, value};
  |                 ^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:226:32
    |
226 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:270:31
    |
270 | fn check_config(cfg_doc: &mut Document, cfg: &mut EtcLqos) {
    |                               ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:175:32
    |
175 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:202:37
    |
202 |   pub fn save(&self, document: &mut Document) -> Result<(), EtcLqosError> {
    |                                     ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/migration.rs:9:16
  |
9 | use toml_edit::Document;
  |                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
  --> lqos_config/src/etc/migration.rs:31:18
   |
31 |         .parse::<Document>()
   |                  ^^^^^^^^

warning: `lqos_config` (lib) generated 7 warnings
warning: unused import: `table_helper::TableHelper`
 --> lqtop/src/widgets/latency_histogram.rs:1:13
  |
1 | use super::{table_helper::TableHelper, TopWidget};
  |             ^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: unused import: `FlowbeeSummaryData`
 --> lqtop/src/widgets/latency_histogram.rs:2:29
  |
2 | use lqos_bus::{BusResponse, FlowbeeSummaryData};
  |                             ^^^^^^^^^^^^^^^^^^

warning: unused import: `lqos_utils::packet_scale::scale_bits`
 --> lqtop/src/widgets/latency_histogram.rs:3:5
  |
3 | use lqos_utils::packet_scale::scale_bits;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: `lqtop` (bin "lqtop") generated 3 warnings (run `cargo fix --bin "lqtop"` to apply 3 suggestions)
    Finished `release` profile [optimized] target(s) in 0.34s
warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/etclqos_migration.rs:4:17
  |
4 | use toml_edit::{Document, value};
  |                 ^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:226:32
    |
226 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:270:31
    |
270 | fn check_config(cfg_doc: &mut Document, cfg: &mut EtcLqos) {
    |                               ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:175:32
    |
175 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:202:37
    |
202 |   pub fn save(&self, document: &mut Document) -> Result<(), EtcLqosError> {
    |                                     ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/migration.rs:9:16
  |
9 | use toml_edit::Document;
  |                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
  --> lqos_config/src/etc/migration.rs:31:18
   |
31 |         .parse::<Document>()
   |                  ^^^^^^^^

warning: `lqos_config` (lib) generated 7 warnings
    Finished `release` profile [optimized] target(s) in 0.31s
warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/etclqos_migration.rs:4:17
  |
4 | use toml_edit::{Document, value};
  |                 ^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:226:32
    |
226 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:270:31
    |
270 | fn check_config(cfg_doc: &mut Document, cfg: &mut EtcLqos) {
    |                               ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:175:32
    |
175 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:202:37
    |
202 |   pub fn save(&self, document: &mut Document) -> Result<(), EtcLqosError> {
    |                                     ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/migration.rs:9:16
  |
9 | use toml_edit::Document;
  |                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
  --> lqos_config/src/etc/migration.rs:31:18
   |
31 |         .parse::<Document>()
   |                  ^^^^^^^^

warning: `lqos_config` (lib) generated 7 warnings
    Finished `release` profile [optimized] target(s) in 0.18s
warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/etclqos_migration.rs:4:17
  |
4 | use toml_edit::{Document, value};
  |                 ^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:226:32
    |
226 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:270:31
    |
270 | fn check_config(cfg_doc: &mut Document, cfg: &mut EtcLqos) {
    |                               ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:175:32
    |
175 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:202:37
    |
202 |   pub fn save(&self, document: &mut Document) -> Result<(), EtcLqosError> {
    |                                     ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/migration.rs:9:16
  |
9 | use toml_edit::Document;
  |                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
  --> lqos_config/src/etc/migration.rs:31:18
   |
31 |         .parse::<Document>()
   |                  ^^^^^^^^

warning: `lqos_config` (lib) generated 7 warnings
warning: unused variable: `json`
  --> lqos_support_tool/src/sanity_checks/net_json.rs:31:24
   |
31 |                     Ok(json) => {
   |                        ^^^^ help: if this is intentional, prefix it with an underscore: `_json`
   |
   = note: `#[warn(unused_variables)]` on by default

warning: unused variable: `json`
  --> lqos_support_tool/src/sanity_checks/net_json.rs:53:12
   |
53 |         Ok(json) => {
   |            ^^^^ help: if this is intentional, prefix it with an underscore: `_json`

warning: field `index` is never read
  --> lqos_support_tool/src/sanity_checks/bridge.rs:93:9
   |
91 | struct IpLinkInterface {
   |        --------------- field in this struct
92 |     pub name: String,
93 |     pub index: u32,
   |         ^^^^^
   |
   = note: `IpLinkInterface` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default

warning: `lqos_support_tool` (lib) generated 3 warnings
    Finished `release` profile [optimized] target(s) in 0.34s
warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/etclqos_migration.rs:4:17
  |
4 | use toml_edit::{Document, value};
  |                 ^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:226:32
    |
226 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:270:31
    |
270 | fn check_config(cfg_doc: &mut Document, cfg: &mut EtcLqos) {
    |                               ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:175:32
    |
175 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:202:37
    |
202 |   pub fn save(&self, document: &mut Document) -> Result<(), EtcLqosError> {
    |                                     ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/migration.rs:9:16
  |
9 | use toml_edit::Document;
  |                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
  --> lqos_config/src/etc/migration.rs:31:18
   |
31 |         .parse::<Document>()
   |                  ^^^^^^^^

warning: `lqos_config` (lib) generated 7 warnings
    Finished `release` profile [optimized] target(s) in 0.14s
warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/etclqos_migration.rs:4:17
  |
4 | use toml_edit::{Document, value};
  |                 ^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:226:32
    |
226 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:270:31
    |
270 | fn check_config(cfg_doc: &mut Document, cfg: &mut EtcLqos) {
    |                               ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:175:32
    |
175 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:202:37
    |
202 |   pub fn save(&self, document: &mut Document) -> Result<(), EtcLqosError> {
    |                                     ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/migration.rs:9:16
  |
9 | use toml_edit::Document;
  |                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
  --> lqos_config/src/etc/migration.rs:31:18
   |
31 |         .parse::<Document>()
   |                  ^^^^^^^^

warning: `lqos_config` (lib) generated 7 warnings
   Compiling lqos_sys v0.1.0 (/root/LibreQoS/src/rust/lqos_sys)
   Compiling lqos_map_perf v0.1.0 (/root/LibreQoS/src/rust/lqos_map_perf)
    Finished `release` profile [optimized] target(s) in 10.11s
warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/etclqos_migration.rs:4:17
  |
4 | use toml_edit::{Document, value};
  |                 ^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:226:32
    |
226 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:270:31
    |
270 | fn check_config(cfg_doc: &mut Document, cfg: &mut EtcLqos) {
    |                               ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:175:32
    |
175 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:202:37
    |
202 |   pub fn save(&self, document: &mut Document) -> Result<(), EtcLqosError> {
    |                                     ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/migration.rs:9:16
  |
9 | use toml_edit::Document;
  |                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
  --> lqos_config/src/etc/migration.rs:31:18
   |
31 |         .parse::<Document>()
   |                  ^^^^^^^^

warning: `lqos_config` (lib) generated 7 warnings
    Finished `release` profile [optimized] target(s) in 0.29s
warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/etclqos_migration.rs:4:17
  |
4 | use toml_edit::{Document, value};
  |                 ^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:226:32
    |
226 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:270:31
    |
270 | fn check_config(cfg_doc: &mut Document, cfg: &mut EtcLqos) {
    |                               ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:175:32
    |
175 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:202:37
    |
202 |   pub fn save(&self, document: &mut Document) -> Result<(), EtcLqosError> {
    |                                     ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/migration.rs:9:16
  |
9 | use toml_edit::Document;
  |                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
  --> lqos_config/src/etc/migration.rs:31:18
   |
31 |         .parse::<Document>()
   |                  ^^^^^^^^

warning: `lqos_config` (lib) generated 7 warnings
warning: unused variable: `json`
  --> lqos_support_tool/src/sanity_checks/net_json.rs:31:24
   |
31 |                     Ok(json) => {
   |                        ^^^^ help: if this is intentional, prefix it with an underscore: `_json`
   |
   = note: `#[warn(unused_variables)]` on by default

warning: unused variable: `json`
  --> lqos_support_tool/src/sanity_checks/net_json.rs:53:12
   |
53 |         Ok(json) => {
   |            ^^^^ help: if this is intentional, prefix it with an underscore: `_json`

warning: field `index` is never read
  --> lqos_support_tool/src/sanity_checks/bridge.rs:93:9
   |
91 | struct IpLinkInterface {
   |        --------------- field in this struct
92 |     pub name: String,
93 |     pub index: u32,
   |         ^^^^^
   |
   = note: `IpLinkInterface` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default

warning: `lqos_support_tool` (lib) generated 3 warnings
warning: unused imports: `Write`, `stdout`
  --> lqos_support_tool/src/main.rs:41:25
   |
41 |     use std::io::{stdin,stdout,Write};
   |                         ^^^^^^ ^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: `lqos_support_tool` (bin "lqos_support_tool") generated 1 warning (run `cargo fix --bin "lqos_support_tool"` to apply 1 suggestion)
    Finished `release` profile [optimized] target(s) in 0.14s
Installing new binaries into bin folder.
Installing lqosd in bin folder
Installing lqtop in bin folder
Installing xdp_iphash_to_cpu_cmdline in bin folder
Installing xdp_pping in bin folder
Installing lqos_node_manager in bin folder
Installing lqusers in bin folder
Installing lqos_map_perf in bin folder
Installing uisp_integration in bin folder
Installing lqos_support_tool in bin folder
warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/etclqos_migration.rs:4:17
  |
4 | use toml_edit::{Document, value};
  |                 ^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:226:32
    |
226 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:270:31
    |
270 | fn check_config(cfg_doc: &mut Document, cfg: &mut EtcLqos) {
    |                               ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:175:32
    |
175 |     let document = raw.parse::<Document>();
    |                                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
   --> lqos_config/src/etc/etclqos_migration.rs:202:37
    |
202 |   pub fn save(&self, document: &mut Document) -> Result<(), EtcLqosError> {
    |                                     ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
 --> lqos_config/src/etc/migration.rs:9:16
  |
9 | use toml_edit::Document;
  |                ^^^^^^^^

warning: use of deprecated type alias `toml_edit::Document`: Replaced with `DocumentMut`
  --> lqos_config/src/etc/migration.rs:31:18
   |
31 |         .parse::<Document>()
   |                  ^^^^^^^^

warning: `lqos_config` (lib) generated 7 warnings
warning: unused variable: `n`
   --> lqos_python/src/device_weights.rs:155:13
    |
155 |     for (i, n) in network.nodes
    |             ^ help: if this is intentional, prefix it with an underscore: `_n`
    |
    = note: `#[warn(unused_variables)]` on by default

warning: `lqos_python` (lib) generated 1 warning
    Finished `release` profile [optimized] target(s) in 3.49s
-----------------------------------------------------------------
Don't forget to setup /etc/lqos.conf!
Template .service files can be found in bin/

Run sudo rust/remove_pinned_maps.sh before you restart lqosd
This ensures that any data-format changes will apply correctly.

from libreqos.

thebracket avatar thebracket commented on August 28, 2024 1

This is what happens when you install the Rust toolchain via apt instead of rustup. The package version doesn't do useful things like actually installing the compiler for your architecture, the cargo toolchain, etc. We've updated build_rust to tell you to do it, and the documentation has included that for a long time - so I'm closing this one.

from libreqos.

interduo avatar interduo commented on August 28, 2024 1

Is it possible to check from what source cargo/rustup comes from somehow? I thought that the priority has binaries from homedir - I need to check that again. I would test that again tommorow (from scratch again).

from libreqos.

interduo avatar interduo commented on August 28, 2024 1

This is what happens when you install the Rust toolchain via apt instead of rustup. The package version doesn't do useful things like actually installing the compiler for your architecture, the cargo toolchain, etc. We've updated build_rust to tell you to do it, and the documentation has included that for a long time - so I'm closing this one.

This is not the case - @thebracket look:

clean the os from rust/libreqos packages/repos/dir

apt purge cargo rustup* libreqos && rm -rf ~/.cargo ~/.rustup ~/LibreQoS /opt/libreqos

clone src code

git clone -b develop [email protected]:LibreQoE/LibreQoS.git && cd ~/LibreQoS
git remote add interduo [email protected]:interduo/LibreQoS.git && git fetch interduo && git pull interduo patch-33

try to build rust

cd ~/LibreQoS/src && ./build_rust.sh

#see error message so run:
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh

$ rustup --version
rustup 1.27.1 (54dd3d00f 2024-04-24)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.79.0 (129f3b996 2024-06-10)`

again try to build

./build_rust.sh &>build_log_1650

see whole build_rust.sh log on: http://kłopotek.pl/build_log_1650
see whole build_dpkg.sh log on: http://kłopotek.pl/build_log_1712

If I didn't clean something I will: "sprinkle ashes on my head"
I open the issue because I would like to investigate all the bad things at earliest possible stage.

from libreqos.

interduo avatar interduo commented on August 28, 2024

@thebracket, please see this compile errors first, maybe its the source of other bugs

from libreqos.

interduo avatar interduo commented on August 28, 2024

This is what happens when you install the Rust toolchain via apt instead of rustup. The package version doesn't do useful things like actually installing the compiler for your architecture, the cargo toolchain, etc. We've updated build_rust to tell you to do it, and the documentation has included that for a long time - so I'm closing this one.

@thebracket tried to resolve that few times in different way. Could You give me advice/guide me how to ommit those warnings/errors?
I did: apt purge cargo and
apt purge rustup

from libreqos.

thebracket avatar thebracket commented on August 28, 2024

I only see warnings there, nothing that should stop it from compiling?

from libreqos.

interduo avatar interduo commented on August 28, 2024

In my instance there is no QoS policy applied, i bet (probably bad) that one of those warnings is responsible for that.

At what moment You clean warnings in code before release beta or rc1?

from libreqos.

thebracket avatar thebracket commented on August 28, 2024

In my instance there is no QoS policy applied, i bet (probably bad) that one of those warnings is responsible for that.

Every single one of those warnings is "you didn't use a variable" or "you used a deprecated code path in the TOML reader" - nothing there that'll stop shaping from happening. My bet would be you need to run LibreQoS.py and check the output?

At what moment You clean warnings in code before release beta or rc1?

Towards the end of the beta cycle. They are harmless, but irritating.

from libreqos.

interduo avatar interduo commented on August 28, 2024

Ok closing this.

from libreqos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.