Splitted Data When Transmission Data Length Exceeding Send Window Limitation about js-libp2p

[achingbrain]

When i am using the sendData function of js-libp2p-yamux in JS-libp2p, there's an issue where if the data to be sent exceeds the send window limit, only the send window amount is transmitted, leaving the rest unsent.

This is by design and how backpressure works in Yamux. If the data to be sent exceeds the window limit, the sender should wait for the remote to increase the limit. This lets the remote signal that it's ready to receive more data.

For instance, if we set the send window to 100 and disable processing receive window updates

If you disable processing window updates you'll not know when it's ok to send more data so things won't work as expected.

In my opinion, it should send the entire data as a single package rather than splitting it into two and waiting for the remaining data to send

If you ignore the send window size, the remote would be within it's rights to close the connection since you aren't following the protocol any more.

I suspect it is caused by the behavior of the stream-muxer in the js-libp2p. It continues to send data to the function 'sendData' without waiting for the previous 'sendData' operation to finish.

Are you sure this is true? The AbstractStream superclass awaits on any promise returned from sendData.

If you're seeing something different can you please open a PR with a failing test case that demonstrates the problem?

[github-actions]

Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 7 days.

[github-actions]

This issue was closed because it is missing author input.