Coder Social home page Coder Social logo

Comments (3)

egli avatar egli commented on June 12, 2024

Hi @benehalo , thanks for all your reports. They are very thorough and professional. I'm at the moment a bit absorbed with my rust rewrite of liblouis so my attention is not so much on liblouis. Nevertheless I'm very interested in solving security issues in liblouis (that was one of the reasons to start the rust rewrite) and I would appreciate some help in solving these issues.

You say that you do not know liblouis well enough to solve the issues, but you seem very competent. I think most of the problems are fairly straightforward to solve. Maybe together we'd have a good chance at solving these. Could you imagine some way were we could collaborate on some of the issues?

Thanks
Christian

from liblouis.

benehalo avatar benehalo commented on June 12, 2024

Hi @egli , I claim that I do not know liblouis well enough to solve the issues, because

  • I only know the superficial cause of these errors, but not the root cause, making it difficult to make critical fixes;
  • and I am also unclear what to do with proper error handling when an error occurs (should report error and exit? Or should catch the error and continue execution?).

I think indeed I can help make some superficial fixes, i.e. adding guards before these crash points and adhering to the error handling code in context (if any).

Do you mind me to make such fixes? If it is ok, I will give corresponding Pull Requests in the near future.

Thanks

from liblouis.

egli avatar egli commented on June 12, 2024

Do you mind me to make such fixes? If it is ok, I will give corresponding Pull Requests in the near future.

I'd love to see such fixes. Anything is better than the status quo.

from liblouis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.