Coder Social home page Coder Social logo

Comments (7)

taldcroft avatar taldcroft commented on July 17, 2024

The upstream SOFA library now has a candidate patch for this issue. This is currently in test and review by the SOFA board. They expect a release no earlier than late October 2013.

from erfa.

eteq avatar eteq commented on July 17, 2024

So should we just wait until the SOFA release @taldcroft, given that it will probably be after astropy 0.3, or would you rather apply the patch here?

from erfa.

timj avatar timj commented on July 17, 2024

Can we get a clue from @scottransom ?

from erfa.

taldcroft avatar taldcroft commented on July 17, 2024

@eteq - Sorry for being a bit vague, but the candidate patch isn't formally available yet. I was offered a preview, but I had the understanding that they really didn't want the code to get out prior to approval by the SOFA board. So I declined and said we would just wait for the SOFA release. (Otherwise their patch would probably be visible to the world as an ERFA PR).

This is a long way of saying, yes, this issue will probably stay open beyond the 0.3 release. The current milestone of "No milestone" is appropriate.

from erfa.

eteq avatar eteq commented on July 17, 2024

Hah, ok, fair enough, @taldcroft. Guess this will need to be added to "known issues" in astropy for 0.3, then. Hopefully by 0.3.1 it'll be out.

from erfa.

scottransom avatar scottransom commented on July 17, 2024

Yes, the board is supposed to be reviewing the candidate patch in SOFA for this issue. It is a slow process with the board, though...

from erfa.

eteq avatar eteq commented on July 17, 2024

As per the discussion in astropy/astropy#1031, it looks like this was fixed in the latest version, which we have currently in master. From http://www.iausofa.org/current_changes.html :

Corrected due to bug with TAI->UTC 1960-1972: d2dtf.c, dtf2d.c, taiutc.c and utctai.c.

So I'll close this now. @taldcroft - if you think the issue still exists in some form, feel free to re-open.

from erfa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.