print fewer warnings about quip

[gabor1]

It's not really a warning, it's telling you what it's doing

[bernstei]

I know what it's doing - I gave it the (lack of) arguments. This message just litters my stdout (or stderr). I'd at least like a quiet mode.

[Sideboard]

How about this:

• Change "WARNING" to "INFO" (or no prefix).
• Change verbosity from normal to verbose (or even nerd).

[jameskermode]

I'd be happy with those changes

[bernstei]

OK. Shall I do a PR?

[jameskermode]

Please go ahead if you have time

[bernstei]

I'm going to code it up with a separate message_type string argument which will be "INFO" here (and default to "WARNING" for backward compatibility), and independent verbosity, although one could imagine having the verbosity derived from the message type. I don't think it's worth it to recreate the complexity of python's logging/warning interface here. If someone else feels strongly about it, feel free to modify my PR or even just let me know.

I would perhaps consider replacing print_warning with print_message, because that can be updated with a search and replace: print_warning(message) -> print_message('WARNING', message)

[Sideboard]

I would prefer for it to not be named print_warning when it may not be a warning at all. Also, print_warning is anyway only a wrapper to not add the prefix explicitly. Is it worth it to have print_message, which then calls print, or could it be print everywhere?

[jameskermode]

Noam’s solution in the PR plus the offer of search and replace for print_message() sounds a good compromise to me.

[bernstei]

I definitely don't want just print, because if nothing else it'll be harder to do with a search and replace (adding a new initial argument is much easier with a regexp), but I'll do print_message().

[bernstei]

Or does that violate the "libatoms is dead, minimal changes only" principle, and I should just revert print_warning and add print_info() function? It's certainly less likely to lead to missed changes.

[Sideboard]

I wasn't aware of that principle. 😅

Both print_message and print_info are possible solutions. I don't think it's likely that you miss a print_warning.

Then again, print_warning is such a simple procedure (a single string argument) that replacing it with print should not be that difficult. Although, I had single lines in mind, with multiple lines it would get ugly. Just checked: 11 out of 67 calls are multilined.

Edit: Oh wait, replacing with print("WARNING: " // should be simpler than replacing with print_message( plus additional arguments for multilined ones. 🤔

[jameskermode]

I think print_warning() -> print_message() is a perfectly good solution. If you do the search/replace I'll approve and merge.

[bernstei]

Take a look at the latest commit.

[jameskermode]

New release v0.9.11 including this PR is now on PyPI, so let the warnings be silenced!