Comments (10)
Please approve this Push Request ~ #52 to allow support for newer devices. @liamfiddler
from eleventy-plugin-lazyimages.
I would also recommend using one of these GitHub action to keep your packages updated:
https://github.com/marketplace/actions/update-version-in-package-json
https://github.com/marketplace/actions/github-action-for-package-json-update
https://github.com/marketplace/actions/automated-version-bump
https://aboutbits.it/blog/2021-03-11-using-github-actions-to-perfom-npm-version-increment
from eleventy-plugin-lazyimages.
I got the same error, it doesn't work on mac due to sharp version
from eleventy-plugin-lazyimages.
Even with the new sharp version? They told me they optimized the last version of sharp to be supported. Can you verify w/ the new pr I made @liamfiddler
from eleventy-plugin-lazyimages.
I dont know if its up already on NPM. I know it takes some time. Can you give me permission to do pull requests on your repo. I'll make sure everything is compatible
from eleventy-plugin-lazyimages.
With the new sharp version, it's working. The old version doesn't work on mac m1.
from eleventy-plugin-lazyimages.
& You should update the examples because to be honest, it gets annoying doing cd & npm installing every example
from eleventy-plugin-lazyimages.
Can you check if its published in NPM so I can add it once again
from eleventy-plugin-lazyimages.
& thanks @ixartz! How did you get it working locally?
from eleventy-plugin-lazyimages.
Current projects using this plugin in 11ty cannot be used because of the use of Sharp. Please upgrade the sharp version and update.
Thanks for raising this, and for making the PR @talmax1124
I don't have a M1, so it took me a few days to borrow a friend's machine and test it, but it's now been merged and published to npm 🎉
I would also recommend using one of these GitHub action to keep your packages updated
Great recommendations, thanks! I'll consider them.
& You should update the examples because to be honest, it gets annoying doing cd & npm installing every example
This is an intentional choice.
I 100% agree it is annoying for editors of the plugin to keep each example up-to-date, but the target audience for the examples are users of the plugin. For this group I've found it's valuable to have a minimal, self-contained example to point at, copy-paste as a starting point, and debug issues if something is going wrong in their project.
That said, if you have an idea to accommodate both groups a PR would be most welcome! 😃
How did you get it working locally?
The easiest way (that I know of) would be to install the package from GitHub instead of the npm registry using a command like npm install --save username/repo#branch-name
.
So to try your forked version they might have used npm install --save talmax1124/eleventy-plugin-lazyimages#master
I'll close this issue because M1 support has been added in the latest release. Feel free to reach out if you have any further questions or issues.
from eleventy-plugin-lazyimages.
Related Issues (20)
- Using with plugin that renames final files? HOT 7
- Different lazyloader? HOT 6
- Img tags with width and height attributes. HOT 2
- For low quality placeholders, an option to write a new file instead of inlining base64 encoded string HOT 4
- lazy image for relative path HOT 5
- GIF handling doesn't seem to be working on the latest version HOT 1
- Error: Could not find MIME for Buffer <null> HOT 4
- Eleventy build issue with posts that have setted tags HOT 4
- png base 64 image are less compressed HOT 3
- Cache not loading HOT 2
- attribute only HOT 2
- noscript output HOT 2
- Trouble installing this plugin, seems to be issue with 'sharp' HOT 1
- Segfault on build HOT 3
- documentation on LQIP HOT 3
- This plugin for background image HOT 2
- Error when requiring plugin. HOT 2
- Disable lazy loading for certain images HOT 2
- How do i set the plugin to not use cdn lazysize.min.js and use local /js/lazysize.min.js instead?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eleventy-plugin-lazyimages.