Coder Social home page Coder Social logo

Comments (10)

talmax1124 avatar talmax1124 commented on June 1, 2024

Please approve this Push Request ~ #52 to allow support for newer devices. @liamfiddler

from eleventy-plugin-lazyimages.

talmax1124 avatar talmax1124 commented on June 1, 2024

I would also recommend using one of these GitHub action to keep your packages updated:

https://github.com/marketplace/actions/update-version-in-package-json
https://github.com/marketplace/actions/github-action-for-package-json-update
https://github.com/marketplace/actions/automated-version-bump
https://aboutbits.it/blog/2021-03-11-using-github-actions-to-perfom-npm-version-increment

from eleventy-plugin-lazyimages.

ixartz avatar ixartz commented on June 1, 2024

I got the same error, it doesn't work on mac due to sharp version

from eleventy-plugin-lazyimages.

talmax1124 avatar talmax1124 commented on June 1, 2024

Even with the new sharp version? They told me they optimized the last version of sharp to be supported. Can you verify w/ the new pr I made @liamfiddler

from eleventy-plugin-lazyimages.

talmax1124 avatar talmax1124 commented on June 1, 2024

I dont know if its up already on NPM. I know it takes some time. Can you give me permission to do pull requests on your repo. I'll make sure everything is compatible

from eleventy-plugin-lazyimages.

ixartz avatar ixartz commented on June 1, 2024

With the new sharp version, it's working. The old version doesn't work on mac m1.

from eleventy-plugin-lazyimages.

talmax1124 avatar talmax1124 commented on June 1, 2024

& You should update the examples because to be honest, it gets annoying doing cd & npm installing every example

from eleventy-plugin-lazyimages.

talmax1124 avatar talmax1124 commented on June 1, 2024

Can you check if its published in NPM so I can add it once again

from eleventy-plugin-lazyimages.

talmax1124 avatar talmax1124 commented on June 1, 2024

& thanks @ixartz! How did you get it working locally?

from eleventy-plugin-lazyimages.

liamfiddler avatar liamfiddler commented on June 1, 2024

Current projects using this plugin in 11ty cannot be used because of the use of Sharp. Please upgrade the sharp version and update.

Thanks for raising this, and for making the PR @talmax1124

I don't have a M1, so it took me a few days to borrow a friend's machine and test it, but it's now been merged and published to npm 🎉

I would also recommend using one of these GitHub action to keep your packages updated

Great recommendations, thanks! I'll consider them.

& You should update the examples because to be honest, it gets annoying doing cd & npm installing every example

This is an intentional choice.

I 100% agree it is annoying for editors of the plugin to keep each example up-to-date, but the target audience for the examples are users of the plugin. For this group I've found it's valuable to have a minimal, self-contained example to point at, copy-paste as a starting point, and debug issues if something is going wrong in their project.

That said, if you have an idea to accommodate both groups a PR would be most welcome! 😃

How did you get it working locally?

The easiest way (that I know of) would be to install the package from GitHub instead of the npm registry using a command like npm install --save username/repo#branch-name.

So to try your forked version they might have used npm install --save talmax1124/eleventy-plugin-lazyimages#master


I'll close this issue because M1 support has been added in the latest release. Feel free to reach out if you have any further questions or issues.

from eleventy-plugin-lazyimages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.