Comments (9)
from eve.
from eve.
@cshari-zededa two points, first of all, you can run yetus easily on your own. Just follow the same steps outlined in our .circleci config yaml https://github.com/lf-edge/eve/blob/master/.circleci/config.yml#L46
Also, personally I have no problems with using PR mechanism to run yetus -- sure your first PR is likely to fail, but that's not that big of a deal and you can always follow up with a change that takes care of yetus feedback. Personally -- even though I can run yetus locally -- I'm tool lazy to do that and just use PR mechnism.
from eve.
I can sympathize here. If I have to wait for a PR test run to report success or failure, it is going to slow down dev cycles. That has led to my personal preference (not always realistic, but preference nonetheless) for my CI config files to always do make <something>
, so that I can run the same thing locally just as easily.
Can we perhaps have a docker image built that contains everything yetus needs (auto-correct keeps changing that to "fetus", which is odd - "contains everything fetus needs"?), so that both circleci and a normal user can just run make ci
or even make yetus
and get the exact same output quickly?
from eve.
I can sympathize here. If I have to wait for a PR test run to report success or failure, it is going to slow down dev cycles. That has led to my personal preference (not always realistic, but preference nonetheless) for my CI config files to always do make , so that I can run the same thing locally just as easily.
I actually don't get it: for me this is the other way around -- PRs are cheap and fire-and-forget. I typically work on a few issues in parallel anyway so while one PR is testing I can spend time doing something else. In fact, this is much easier than to try and run things locally. Once yetus posts its feedback on a PR -- fixing it is typically super straightforward as well.
Can we perhaps have a docker image built that contains everything yetus needs (auto-correct keeps changing that to "fetus", which is odd - "contains everything fetus needs"?), so that both circleci and a normal user can just run make ci or even make yetus and get the exact same output quickly?
We already have that container and how to run it specified in a circleci config. If you want to hook it up to Makefile -- sure that'd be fine, but personally I have no need for it so it'll have to be one of you guys actually doing the work ;-)
from eve.
I actually don't get it: for me this is the other way around -- PRs are cheap and fire-and-forget. I typically work on a few issues in parallel anyway so while one PR is testing I can spend time doing something else
Different strokes for different folks and all that. :-)
from eve.
We already have that container and how to run it specified in a circleci config. If you want to hook it up to Makefile -- sure that'd be fine, but personally I have no need for it so it'll have to be one of you guys actually doing the work ;-)
Consider it done. If it makes life easier for some people, happy to see it done. See #185
from eve.
FWIW, a make yetus
rule got added when #195 was merged, so this issue may deserve to be closed. There may be some bugs with the implementation, but those probably should be filed as new issues.
from eve.
Agreed. If there are bugs, they should be under new issues. If the way to run it isn’t sufficient, then we need a new issue describing such improvement.
Closing.
from eve.
Related Issues (20)
- fTPM on ARM HOT 1
- Replace (part of) kvm/qemu with firecracker/rust-vmm
- Try kata containers with k3s
- Observable memory usage in kvm/qemu to predict OOM HOT 1
- App PCIe passthrough should deny takeover of zfs owned devices
- Integration of tee-utils and tee-supplicant daemon
- Add more DTB overlays to Raspberry PI
- Get more information about the hardware and sensors as well
- Live image doesn't boot when EVE-OS is installed on another storage device
- Add some local commands to be used by local administrators HOT 1
- Request: Add Container-Name in Prompt for all our service containers similar to pillar
- Document meta-data server access limitations
- Static IP override via USB but fallback to DHCP if no connectivity
- Update version of Alpine to build EVE
- bug: fatal: agent zedbox[1553]: zboot partstate IMGA: err signal: user defined signal 2 HOT 24
- commercial controller fails Device Info mesage with Bad Request: ntp sources info is nil for dev HOT 2
- CI/CD: hitting DockerHub pull rate limit a.k.a. TOOMANYREQUESTS HOT 32
- chronyd.pid watchdog on recent master HOT 8
- mkimage-raw-efi references lower-level serial container dir directly and shouldn't HOT 3
- Adam and EVE-OS initial deploy issue HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eve.