Comments (4)
Mostly ssd1306 is C-style library and I don't think that __has_include
is supported by all compilers.
Regarding your fix: TWI
is not supported for all AVR controllers as well as AVR SPI
. This will break other platforms.
I agree with other your proposals.
from ssd1306.
The __has_include
check is written to first check whether the compiler supports __has_include
.
#if !defined __has_include || __has_include(<Wire1.h>)
The #include <Wire1.h>
is skipped only when the compiler both supports __has_include
and when __has_include
indicates no Wire1.h file exists.
from ssd1306.
As the code #else
case is written today, all platforms (not matched by the specific cases) without TWI using are already broken, because CONFIG_TWI_I2C_AVAILABLE
is always defined. Checking only for __AVR__
shouldn't break anything that isn't already broken, but it would indeed leave unknown AVR platforms without TWI broken.
Maybe a better test would look something like this?
#if defined(__AVR__) && defined(TWBR) && defined(TWCR)
#define CONFIG_AVR_SPI_AVAILABLE
#endif
from ssd1306.
If it would help, I can arrange to send you a free Teensy 4.0 and Teensy 4.1 for software testing.
from ssd1306.
Related Issues (20)
- Working on a IP Camera - Anyka HOT 2
- pgmspace.h issue since 1.8.3 HOT 5
- ssd1306_setRotation
- How to use this in Linux running non single board computer (laptop's i2c port) HOT 1
- Apparent hang in AVR TWI communications when display absent
- nano_gfx_types.h defines macros which pollutes the global namespace and cause compile errors
- Add support for recent series of attiny MCUs HOT 2
- Support Pi Pico / RP2040 Microcontrollers HOT 3
- I2C definition for ESP32 Espressif HOT 3
- How to port it to ESP IDF HOT 1
- Potential Conflict AHTX10/AHT10 and LCDGFX HOT 2
- "Failed to Initialize: No such file or directory!" on RPI zero 6.1.21+ #1642 Mon Apr 3 17:19:14 BST 2023 armv6l GNU/Linux HOT 1
- Print text at any Y-value? HOT 1
- Larger fonts possible? Turn off/on display? HOT 2
- Error compiling ssd1306_demo HOT 3
- how to convert custom fonts ? HOT 1
- How to specify i2c bus on linux? HOT 1
- None of examples load on attiny44 HOT 4
- ssd1306_demo
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ssd1306.