Coder Social home page Coder Social logo

Comments (11)

Lewiscowles1986 avatar Lewiscowles1986 commented on May 24, 2024

Apologies, I'll dig into this, it is likely something to do with the github action used to deploy as all I changed was the supported version header.

from wordpresssvgplugin.

Lewiscowles1986 avatar Lewiscowles1986 commented on May 24, 2024

Can you give more specific examples? I just set this up by downloading the zip and installing on a 5.7.2 site.

What wp-cli command are you running?
Can you work with me to see this through to resolution?

from wordpresssvgplugin.

marcustallberg avatar marcustallberg commented on May 24, 2024

I don't think wp-cli is related to error, it was only a way to get a more detailed error message when /wp-admin was unreachable. The command however was wp plugin list.

This manifested itself by the plugin being set to self-update automatically.

from wordpresssvgplugin.

Lewiscowles1986 avatar Lewiscowles1986 commented on May 24, 2024

Do you think if I prepare an asset for you to test you would be able to confirm if it breaks your setup before I release to wp-dot-org? (I already know it doesn't break mine, and I don't know, but can guess why it might be breaking yours)

from wordpresssvgplugin.

Lewiscowles1986 avatar Lewiscowles1986 commented on May 24, 2024

enable-svg-uploads.2.1.3.zip

Here's the asset, it's a modified index.php with changed version check (not related to this issue) and re-ordering of require.

I am sorry this broke your site, and will try to do better in-future. This is uploaded to a host and manually tested through to uploading an SVG, so I don't quite know how I missed this.

from wordpresssvgplugin.

Lewiscowles1986 avatar Lewiscowles1986 commented on May 24, 2024

All this and it was a missing \

I found if I clear the caching layer my site captures the error too.

from wordpresssvgplugin.

Lewiscowles1986 avatar Lewiscowles1986 commented on May 24, 2024

2.1.4 coming at you with the fix 👍

from wordpresssvgplugin.

marcustallberg avatar marcustallberg commented on May 24, 2024

The zip package you provided earlier still raises an error:
Screenshot 2021-05-29 at 8 21 59

from wordpresssvgplugin.

Lewiscowles1986 avatar Lewiscowles1986 commented on May 24, 2024

Can you check the version from wordpress.org?

If it's broken, I'll dig into it more, but I've just installed it across three sites and uploaded SVG's. One of the sites has never used this plugin before.

from wordpresssvgplugin.

marcustallberg avatar marcustallberg commented on May 24, 2024

Wordpress version: 5.7.2

And now I can confirm the following when testing the different versions:
2.1.4 works
2.1.3 breaks the site
2.1.2 works

from wordpresssvgplugin.

Lewiscowles1986 avatar Lewiscowles1986 commented on May 24, 2024

I added a note to the plugin directory page apologizing for 2.1.3, and providing 2.1.4. I'll close this now as 2.1.4 can now receive auto-updates and is protected against this issue. It is strange the 2.1.3 didn't work, but perhaps the manual editing of the zip file didn't fix.

Thanks for your patience and understanding.

from wordpresssvgplugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.