Comments (5)
After fiddling around some more, I've found that add_terms()
doesn't handle search modifiers like <, >, !, etc. I threw together some code that generates a Term
given the field and value with the correct modifier.
from auraxium.
I like your generate_term
method to let users use modifiers in the kwarg-style terms. I think we should still expose a manual way of adding them (i.e. the missing add_term
method), I was originally trying to avoid the modifier literals.
That said, considering how much shared functionality there is between Join
and Query
(adding/removing terms, adding joins, showing and hiding fields, ...), it might be worth moving these shared functions into a common base class down the line.
from auraxium.
That would be an interesting experiment. I might give it a shot and see if it makes things simpler or more complex. That's my biggest concern, really, is that things become too complicated to maintain and improve.
For better or for worse, the reason I was able to contribute to this project was because everything was simply laid out and I could follow what the code was doing instantly. The more we abstract the code, the harder it will for someone new to understand what is going on.
from auraxium.
Thoughts on what we should to about terms()
? It doesn't seem particularly useful, since it expects a list of Term
s. On the other hand, it does allow you to reset the list of terms or set it easily if you've already generated the list earlier in the code.
My first choice would be to get rid of it. self.terms
is public, so it is possible to manually set the value. The name also conflicts with add_terms
, and you would have to look at the documentation or source code to understand what each one does.
from auraxium.
My first choice would be to get rid of it.
I share that sentiment. As I mentioned before, I made some questionable decisions in the first go-around of this wrapper, such as making any query commands methods.
I am currently in the process of blocking out the new object model, and the Query/Join methods will also get their refactoring to make sure they play along nicely with the object-oriented interface. I will publish the branch as soon as I feel like it's on the right track so it can be discussed before continuing that route.
from auraxium.
Related Issues (20)
- Fix unit test workflow for forks HOT 1
- weapon datasheet 'max' and 'min' damage are meaningless due to API quirks HOT 2
- Reconsider object model getter helpers
- Note GainExperience quirks in documentation HOT 1
- Faction image_path missing HOT 1
- outfit.leader() -> Character or OutfitMember HOT 2
- ('experience_bonus',), 'msg': 'value is not a valid integer', 'type': 'type_error.integer'}])> HOT 2
- Improve error message when pydantic validation fails
- RTD broken link HOT 1
- Allow unsecured connections for expired API certs HOT 3
- WebSocket version migration HOT 1
- Support third-party fallback endpoints HOT 1
- Uncaught exception on await Character.items(): KeyError HOT 5
- README example is raising RuntimeError HOT 2
- Client.get_by_name not using name.first_lower HOT 3
- Ignoring Unsupported Payload (Continent Lock) HOT 1
- Move payload validation to OpenAPI spec
- ClientResponseError: 400, message='Bad Request' when querying census API HOT 4
- events.ContinentUnlock no longer exists HOT 1
- Unable to add World to Trigger filter HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from auraxium.