Coder Social home page Coder Social logo

Comments (7)

LeoNatan avatar LeoNatan commented on May 28, 2024

Hi,

Have you also implemented the defaultFrameForBottomDockingView method? It tells the system where to position the popup bar.

from lnpopupcontroller.

KevinVitale avatar KevinVitale commented on May 28, 2024

@LeoNatan Yep. Looks like this.

extension ViewController {
    override public func bottomDockingViewForPopup() -> UIView {
        return _playerDockingView
    }

    override public func defaultFrameForBottomDockingView() -> CGRect {
        var bottomViewFrame = _playerDockingView.frame
        if _playerDockingView.hidden {
            bottomViewFrame.origin = CGPoint(x: 0, y: view.frame.size.height)
        } else {
            bottomViewFrame.origin = CGPoint(x: 0, y: view.frame.size.height - _playerDockingView.frame.size.height)
        }
        return bottomViewFrame
    }
}

from lnpopupcontroller.

KevinVitale avatar KevinVitale commented on May 28, 2024

@LeoNatan: I've created a test project that recreates the issue I'm seeing:
https://github.com/KevinVitale/TestPopUP

Anything you can do to point me in the right direction would be very helpful! Thanks for your time, and for the project (it's splendid).

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on May 28, 2024

Thanks, this will be helpful! Will look soon.

from lnpopupcontroller.

KevinVitale avatar KevinVitale commented on May 28, 2024

Any feedback on this? Much appreciated.

from lnpopupcontroller.

LeoNatan avatar LeoNatan commented on May 28, 2024

Fixed.

from lnpopupcontroller.

KevinVitale avatar KevinVitale commented on May 28, 2024

Many, many thanks!

from lnpopupcontroller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.