Comments (7)
Hi,
Have you also implemented the defaultFrameForBottomDockingView
method? It tells the system where to position the popup bar.
from lnpopupcontroller.
@LeoNatan Yep. Looks like this.
extension ViewController {
override public func bottomDockingViewForPopup() -> UIView {
return _playerDockingView
}
override public func defaultFrameForBottomDockingView() -> CGRect {
var bottomViewFrame = _playerDockingView.frame
if _playerDockingView.hidden {
bottomViewFrame.origin = CGPoint(x: 0, y: view.frame.size.height)
} else {
bottomViewFrame.origin = CGPoint(x: 0, y: view.frame.size.height - _playerDockingView.frame.size.height)
}
return bottomViewFrame
}
}
from lnpopupcontroller.
@LeoNatan: I've created a test project that recreates the issue I'm seeing:
https://github.com/KevinVitale/TestPopUP
Anything you can do to point me in the right direction would be very helpful! Thanks for your time, and for the project (it's splendid).
from lnpopupcontroller.
Thanks, this will be helpful! Will look soon.
from lnpopupcontroller.
Any feedback on this? Much appreciated.
from lnpopupcontroller.
Fixed.
from lnpopupcontroller.
Many, many thanks!
from lnpopupcontroller.
Related Issues (20)
- Safe area insets are not maintained correctly in iOS 16 HOT 13
- UIView+LNPopupSupportPrivate.m - Line 296 - valueForUndefinedKey:]: this class is not key value coding-compliant for the key backgroundTransitionProgress HOT 4
- Use the -beginAppearanceTransition:animated: and -endAppearanceTransition APIs HOT 4
- Hope it's not too complicated HOT 1
- Question
- Incorrect popupPresentationState returned after delegate call HOT 4
- SPM resource management is not working HOT 6
- iOS 14 : [<UITabBar 0x11796b300> valueForUndefinedKey:]: this class is not key value coding-compliant for the key backgroundTransitionProgress. HOT 1
- PopupBar is disappearing after hidesBottomBarWhenPushed HOT 1
- Failing builds on Azure Pipeline with Xcode 14. HOT 3
- Carthage build failed with Xcode 14.3 HOT 7
- Left image in popupItem
- iOS 17: New “Floating" Popup Bar Style HOT 10
- iOS 17: Scroll edge appearance does not animate when presenting/dismissing popup bars
- Example App Crashes on launch HOT 15
- Style question HOT 10
- SwiftUI preview does not compile with missing required module 'LNPopupController_ObjC HOT 13
- Floating background color HOT 7
- Larger text sizes / content categories look bad HOT 32
- Bat layout is broken under certain extreme situations HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lnpopupcontroller.