UINavigationBar positioned wrong in child (contained) UINavigationController about lnpopupcontroller

[JozefLipovsky]

seems to be related to this one #41, make sure you are using latest version.... I have just tested this in my app and it's working fine when VC is embeded in UINavigationController

[funkenstrahlen]

I am using the latest version. This did not fix it.

However my view hierarchy looks like this, which might be the problem why the fix does not work for me.

popup presents: UIViewController -> UIPageViewController as subview -> UINavigationController -> UIViewController

[LeoNatan]

From the screenshots above, I see this is not the latest version. Please update to latest version.

[funkenstrahlen]

I am currently trying to figure this out

➜  xenim-ios-app git:(feature/chat) carthage update
*** Fetching LNPopupController
*** Checking out LNPopupController at "v1.3"
*** xcodebuild output can be found in /var/folders/8r/nl9r6g3s2j36ljrhdnky9ng40000gn/T/carthage-xcodebuild.Np529A.log
*** Building scheme "LNPopupController" in LNPopupController.xcodeproj

Carthage says I have the current version.

However it is really hard to find out if the code actually has this version, because there is no version number fixed in any files of the repository to crosscheck.

I only found something in Info.plist, but it is outdated: https://github.com/LeoNatan/LNPopupController/blob/master/LNPopupController/Info.plist#L10

[funkenstrahlen]

I just took a look right in the code and can confirm that the version carthage did checkout actually includes this patch: ac6d3f9

So I assume carthage did build 1.3 correctly.

How can you see my build uses an older version?

[LeoNatan]

Hmm, because the popup dismiss button is on top of the bar. But I see you are embedding a navigation controller in a view controller. This all might be iOS fault. Please move the content controller to be a navigation controller directly.

[funkenstrahlen]

Unfortunately I can not do that because the UINavigationController is just one of my views inside a UIPageViewController. So the popup content controller has to be either the UIPageViewController directly or a UIViewController containing it.

Would also be nice if you could update the version string in Info.plist

[funkenstrahlen]

If I swipe the UIPageViewController left and right, the UINavigationBar is displayed correctly. It just breaks if the popup is minified. I assume Apples code does not handle the additional top space correctly.

[LeoNatan]

That's what I fear. There are many issues with embedding navigation controllers that just don't work well. Unfortunately there is little I can do. Will take a look but will likely close this as an Apple bug.

[funkenstrahlen]

That's what I fear. There are many issues with embedding navigation controllers that just don't work well. Unfortunately there is little I can do. Will take a look but will likely close this as an Apple bug.

I understand.

This is how it behaves: