Coder Social home page Coder Social logo

Comments (9)

bronger avatar bronger commented on June 22, 2024

Thank you for your contribution! Did you put control points on straight lines in Hugin, or did you do a 360° panorama?

Original comment by: bronger

from lensfun.

bronger avatar bronger commented on June 22, 2024

According to http://wilson.bronger.org/lensfun_coverage.html, there is already the 50mm in the database, but with a bigger crop factor, so your contribution is welcomed.

Original comment by: bronger

from lensfun.

bronger avatar bronger commented on June 22, 2024

I took raw photos of a skyscraper and manually added control points on straight lines. Hugin displays only 3 or 4 digits, so I took the parameters directly from inside the .pto file.

I've tested the corrected distortion on different images. After correction in Darktable, I don't see any more distortion, including in the corners. So for my lenses, the correction is perfect.

The TCA correction is also good, but not perfect on the 20mm lens at 100% or 200%. I'm not sure yet if it's a problem with ptlens model or darktable interpolation/demosaicing...

I'm also working on the vignetting correction, but no good results so far.

Original comment by: nlann

from lensfun.

bronger avatar bronger commented on June 22, 2024

It must be a very recent addition, I don't have it in the source I got on
05/04. I will update, thanks.

Original comment by: nlann

from lensfun.

bronger avatar bronger commented on June 22, 2024

As for the vignetting correction, I recommend my method at http://wilson.bronger.org/lens_calibration_tutorial/#id3.

Original comment by: bronger

from lensfun.

bronger avatar bronger commented on June 22, 2024

I pushed your contributions to the git master and close this ticket now. Thank you again!

Original comment by: bronger

from lensfun.

bronger avatar bronger commented on June 22, 2024
  • status: open --> accepted

Original comment by: bronger

from lensfun.

bronger avatar bronger commented on June 22, 2024
  • status: accepted --> closed

Original comment by: bronger

from lensfun.

bronger avatar bronger commented on June 22, 2024
  • status: closed --> implemented

Original comment by: bronger

from lensfun.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.