Comments (7)
Upstream seemed to have a similar issue on this week snapshot which was because loader entrypoint was too late for this version. I’ll test if it got fixed at the same time and else I’ll open an issue in loader repo.
from fabric.
I've determined that this issue has 2 causes:
- In newer versions, the game options are loaded after mod initialization. In 7.10, the game options are loaded before mod initialization. Legacy Fabric Keybinding API injects the modded keybinds via a mixin for game options loading, introducing a race condition where mod keybinds haven't been registered yet when the API attempts to inject them. I've worked around this here: https://github.com/Nolij/Zume/blob/844e625eb94e55ade0828271ef3de0d4d3cd98a3/legacy/src/main/java/dev/nolij/zume/legacy/LegacyZume.java#L26-L31
- If keybinds are added for a non-existent category, no category is registered. I've worked around this here: https://github.com/Nolij/Zume/blob/master/legacy/src/main/java/dev/nolij/zume/legacy/mixin/KeyBindingMixin.java
With the two workarounds I linked, the issue doesn't occur (at least for my mod; other mods will still have problems). The second fix is necessary for all Legacy Fabric versions. The first one is only necessary for <=7.10.
from fabric.
I fixed this in speedrunigt by just initializing keys in GameOptions (RedLime/SpeedRunIGT#88)
from fabric.
I fixed this in speedrunigt by just initializing keys in GameOptions (RedLime/SpeedRunIGT#88)
Actually this is way better I'm going to do that instead.
from fabric.
Just realized I forgot to open the issue on loader repo.
from fabric.
Just realized I forgot to open the issue on loader repo.
Link?
from fabric.
We can probably add a KeybindingsRegistryEvent to help with it. You would have to subscribe to it from a ModInitializer instead of a ClientModInitializer tho.
from fabric.
Related Issues (20)
- [1.7.10] Logger error HOT 1
- Multiproject setup HOT 2
- [Registry-Sync-API] Unable to place some blocks in world HOT 2
- [Networking-API] Villager trades become empty HOT 1
- [1.7.10][Rendering-API] ItemRendererHook is still not ported
- No 1.1 support
- [RegistrySync] Crash when load an existing world with a new mod with additional blocks or items HOT 1
- EnderZombie JSON Lang file reading library HOT 2
- [1.8.9] Weird Failed to launch using launcherwrapper HOT 3
- [Suggestion] Modrinth version HOT 3
- [1.8.0-1.8.9] Item model is found but not used by ItemRenderer.
- Stop being Microsoft please HOT 1
- When I start "runClient",It Will be crash. HOT 5
- Couldn't locate the game! HOT 2
- resource-loader-v1-common uses deprecated methods
- [1.8-1.9] The sign cannot run commands HOT 3
- [KeyBindingAPI] Category should be registered automatically
- [LFAPI 1.9.2] Crash on Startup
- [1.4.7] Backport Keybinding & Resource Loader APIs to 4.7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fabric.