Comments (1)
That is wrong. This is why.
Instead of having the application container keep track of that information... What I really want is for the sidebar and the routeComponent to be rendered properly.
- If the sidebar is open, and the screen is small, then I should just show the sidebar. The routeComponent should display none.
- If the sidebar is open, and the screen is big enough, then I should display the sidebar and the routeComponent.
Therefore, all I really need to do is complete the task on #41. Then the SidebarContainer can continue telling the Sidebar component whether he should be visible (state.sidebar.visible === true), and the ApplicationContainer can tell the Application component whether he should be visible (hidden = state.screenSize.small && state.sidebar.visible).
from react-demo.
Related Issues (20)
- Application component should listen to browser width
- App doesn't load at localhost root
- Do isomorphic rendering
- FIgure out how I'll do async api request stuff HOT 2
- Sidebar float left style is broken HOT 1
- Sidebar needs tabs
- Figure out why sinon isn't working... HOT 1
- Refactor reservation form group into a generic form component
- Extract test helpers from Reservations component test
- Add date picker to reservations ui
- Add a complete reservation form HOT 1
- Implement swiping from day to day on reservations ui
- Add configuration for capacity
- Reservations UI should change based on which user you are
- Add a waiting list
- Reservations component needs onDateChange()
- Move application component event handler to componentDidMount
- Stub the reservations ajax service
- Add next/previous day to reservations
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-demo.