Comments (4)
Do you have a test audio file so I can reproduce the bug?
On Sun, Jan 26, 2014 at 2:42 PM, Sahat Yalkabov [email protected]
wrote:
After hours and hours of pulling my hair, thinking there was something wrong with another library I am using, or perhaps a bug in fs.createReadableStream it turns out the latest version of musicmetadata has a bug.
I rolled back to v0.3.0 and metadata event is fired once as it supposed to.Now as you can imagine firing this event twice was causing problems with
async
library callingcallback(null, meta)
twice which would throw an error, and in other case it would try to create database element twice and fail because of duplicate SQL entry.Reply to this email directly or view it on GitHub:
#41
from musicmetadata.
Hi, I was able to narrow down the problem further by testing various audio files. Some of my songs emit double meta
event while others fire once.
Here are the songs that causes meta event to fire twice:
And here the songs that behave normally:
The only difference I see is in the encoding type. Your library doesn't seem to play well with non-LAME3 file encoding. At least as of version 0.3.1 with the introduction of duration option, which by the way is awesome and totally useful!
from musicmetadata.
Could you send me one of the failing audio files?
from musicmetadata.
I can confirm it is fixed now. Thanks!
from musicmetadata.
Related Issues (20)
- 'Could not find metadata header' with some mp3s HOT 5
- No metadata in file that has metadata HOT 2
- Webpack, fs and HTML 5 File object HOT 1
- Misleading examples: the Readable Stream should be closed HOT 3
- error when extract image HOT 3
- Error: expected frame header but was not found. FLAC files parsed with id3v2 parser? HOT 2
- Dump complete metadata? HOT 1
- Rating tag support HOT 3
- Chapter Addendum? HOT 1
- Warning: Possible EventEmitter memory leak detected. HOT 1
- [Question] Is there a way to not parse / load the picture buffer HOT 3
- Chrome freezes/locks up while loading FLAC metadata from arraybuffer HOT 2
- Completion callback invoked twice HOT 1
- Callback is never called HOT 4
- Webpack with electron-renderer target imports non-browser-wrapped version
- using file upload control HOT 1
- Doesn't support OGG. HOT 2
- Do not provide duration of audio HOT 4
- File's picture
- Metadata output doesn't include composer tag
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from musicmetadata.