Coder Social home page Coder Social logo

Comments (4)

leefsmp avatar leefsmp commented on September 26, 2024

That's because the production code doesn't support splitter to be wrapped in a custom component. So only fix I can think of would be to have the function ReflexSplitter.isA() work with wrapped splitter. The proposed solution is issue #49 was to use code as below:

isSplitterElement (element) {
    return element.type === (<ReflexSplitter/>).type
} 

but I don't know if this might impact runtime performances as it will be invoked many times while interacting with a splitter and look like it has to instantiate a ReflexSplitter component somehow. Maybe I can try to store in a class member (<ReflexSplitter/>).type during an initialization ...

from re-flex.

leefsmp avatar leefsmp commented on September 26, 2024

I can't find a way to scan the element at runtime if this is a component that wraps a ReflexSplitter, maybe there is a way but it's beyond my React skills.

However a rather straightforward workaround would be to export ReflexSplitter with a different name from your lib as in:

//your-lib-exports.js
import {
  ReflexSplitter
} from 'react-reflex'

const SplitterControl = ReflexSplitter

export {
  SplitterControl
}

then customize .ReflexSplitter with css. As far as I can tell, I've never seen a case where a splitter needs to implement any logic inside a wrapping component, so you should be able to get away with this.

from re-flex.

karanmidha avatar karanmidha commented on September 26, 2024

Thanks for the replies @leefsmp. Yes, this was my last resort.

from re-flex.

karanmidha avatar karanmidha commented on September 26, 2024

This issue has been fixed in v4.2.5. Thanks @leefsmp

from re-flex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.