Coder Social home page Coder Social logo

Comments (3)

hamishforbes avatar hamishforbes commented on August 16, 2024

Is there any point in using the ngx.thread method if we're just going to wait until we're done with the normal request processing before firing a background request anyway?

from ledge.

pintsized avatar pintsized commented on August 16, 2024

No, probably not. Well, unless the thread protects the connection from closing prematurely in any way? Otherwise I think it's just a code sequence refactor.

from ledge.

hamishforbes avatar hamishforbes commented on August 16, 2024

Even if we move the background revalidate request to after the ngx.eof() call with ESI there is the issue of what to do with sub-requests.
If they are also being served stale and revalidated in the background then that will block the main request until the ESI fragment has revalidated in the 'background', even though its returned stale content.
We can use ngx.is_subrequest var to prevent background revalidating sub-requests as this is never going to be a useful thing to do unless its truly run in the background.

Additionally should we be passing on the sub-request's Warning header when it is served stale but the main request is not? That would seem like the right thing to do.

from ledge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.