Config mechanism is unclear about ledge

[pintsized]

It may be worth considering the following new feature, available in OpenResty 1.2.1.5:

feature: added new configure directives init_by_lua and
init_by_lua_file. they can be used to pre-load Lua modules,
register true Lua global variables, and initialize the
shared-memory storage defined via lua_shared_dict, at Nginx
config-loading time. thanks drdrxp for suggesting this new
feature.

[bakins]

Could all the config be in a module that would be loaded via init_by_lua?

[pintsized]

Could all the config be in a module that would be loaded via init_by_lua?

I think using init_by_lua for loading ledge (and resty.rack) makes a lot of sense, and on initial tests does improve performance. By loading the code module globally, but placing all config into ngx.ctx, we have the best of both worlds in terms of performance and flexibility.

This being said, if ledge.set() acted globally (in a local table) when loaded with init_by_lua you could feasibly load global config options only once per server reload.

I'm not sure if ledge will know what phase it is though? (perhaps that's a feature req for lua-nginx-module?). Maybe we'd need ledge.gset() for use within init_by_lua? Worth looking into.

[pintsized]

This is looking ok for now. There will be further changes, but at least the ambiguity has been removed.