Coder Social home page Coder Social logo

sinatra-views's Issues

Consider changing "hard coded" local host 9393

Is http://localhost:9393/ the most likely location of any user's shotgun sample? Would it be better to point the user to the shotgun command's output for the location? E.g. here's what my output was:

[14:52:58] (master) sinatra-views-cb-000 // ♥ shotgun == Shotgun/Thin on http://138.68.11.226:30000/ Thin web server (v1.6.3 codename Protein Powder) Maximum connections set to 1024 Listening on 138.68.11.226:30000, CTRL+C to stop

Duplicate text in the README

Hi. It looks like the section "Part 3: Multiple Routes with Multiple Views" repeats a few sentences that were in "Part 1: Rendering HTML". In Part 3, you have this paragraph:

"Run shotgun and go to http://localhost:9393 or the IP Address:PORT provided by the Learn IDE. Your "Hello World" text should now appear as an <h1>. Nice! With shotgun running, head to http://localhost:9393/info . You should see "Testing the info page" rendered there. This lets us know that our route is defined properly. Next, let's have this route render a separate file instead. Inside of the views directory, create a file called info.erb. Add whatever HTML code you like."

The part of the paragraph that I bolded and italicized is from Part 1 and is not needed in Part 3.

Thanks for looking into this!
Sdcrouse

There's a misleading sentence in the README

Hi. Let me preface this by saying that I may be nitpicking here, so please feel free to take it or leave it. I noticed that in Part 3 of this lab, there's a sentence that says, "Add whatever HTML code you like." Then, it shows the following HTML:

<!DOCTYPE html>
<html>
    <head>
        <title>Info Page</title>
    </head>
    <body>
        <h1>Info Page</h1>
        <p>This is the info page: here's some information about me!</p>
    </body>
</html>

I think the sentence that I mentioned needs to be changed to something like "Add the following code into that file, and whatever else you like:".

My reason for this is that the tests won't pass without that specific HTML, contrary to what the original sentence implies.

Thanks for looking into this!
Sdcrouse

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.