The react-introduction-to-react-router's discuss from learn-co-curriculum

Suggestions for including information in this lesson re: accessibility issues around SPAs for visually impaired folks using text readers.

Hello. I have read a few blog posts about how one of the drawbacks of SPAs is that it is difficult for text readers/assistive technologies to read the app. It would be great to include a few lines about this so people are aware!

Here's a great blog post about it.

Thanks!

Redux

The first paragraph talks about how we have learned to move state to a store using Redux and that's a couple weeks after this gets deployed.

Lesson "Next" Button links to Incorrect Page

Link to Canvas

https://learning.flatironschool.com/courses/1883/pages/introduction-to-react-router?module_item_id=259645

Issue Subtype

Describe the Issue

Source

<a href="https://learning.flatironschool.com/courses/1883/modules/items/259647" role="button" class="Button" aria-describedby="msf0-next-desc" aria-label="Next Module Item">
          Next<i class="icon-mini-arrow-right"></i>
          <span id="msf0-next-desc" class="hidden" hidden="">Next: React Components as Routes Lab</span>
</a>

Concern

"Introduction to React Router" reading's "Next" button at bottom of the page links to the incorrect lesson. It currently takes you to the "React Components as Routes" Lab and skips the "Introduction to React Routes" Lab. This was very confusing as this skips the intro needed on how to create routes. I was able to find the skipped lab but needed to manually look back at the module list.

(Optional) Proposed Solution

Update the href tag tied to the "Next" button to link to the correct Lab.

What OS Are You Using?

Any Additional Context?

Typo

"We have to plan out all the possibilities that might happen on the Client-Side, this might feel like we are repeating designs that we have already completed with out server routes and and models."

out => our

Sitelinks broken

clicking any link returns: "This site can't be reached"

Update for React Router v6

Update links to v5 documentation
Add note about v6 release

way or method

Add "way" or "method" after JavaScript in this sentence:
"So that is the JavaScript to emulate the experience of using the back button in the browser toolbar."

Thank you.

Wait, is that a `var` in the Flatiron curriculum?

var newState = {
  goal: "Learn about pushState()"
};
 
window.history.pushState(newState, "new state", "new-state");

This part feels like an incomplete thought

It is good to know though, that modern search engine spiders are able to read

Unlike similarly formatted parts of this readme, this doesn't end with a period. We could, of course, just add one, but even then it feels like an incomplete thought. I know what it's getting at, but it feels awkward to me.

replace term "differently-abled"

The term has pretty broad disapproval from disabled communities (a Google search for the term alone will return a number of articles explaining why, probably as the first few results)

learn-co-curriculum / react-introduction-to-react-router Goto Github PK

react-introduction-to-react-router's Issues