Comments (6)
See also discussion on zulip: https://leanprover.zulipchat.com/#narrow/stream/147302-lean4-dev/topic/Expose.20--load-dynlib.20to.20Lean.3F/near/264029782
from vscode-lean4.
From Gabriel: On a high level, the biggest question is how the fallback should work. That is, when do we try lean --server after lake serve fails? Do we just call lake serve if there is a lakefile.lean present?
There's also a lot of tiny annoyances left. The extension has a configuration for the lean executable. Do we add one for lake as well? There is some version selection code by Chris which also makes it a bit harder to change replace lean --server by lake serve.
From Sebastian: Can we replace this with a setting for the toolchain root path (keeping bin/lean as the sanity check)? I'd like to avoid tying this to elan if not necessary.
from vscode-lean4.
Proposal, replace the following setting:
Then the rules for using lake serve
would be:
- is 'lake' or 'lake.exe' found in the toolchainPath, If not don't use
lake
- is there a
lakefile.lean
in the current workspace root? If not don't uselake
- If the above are both good, use
lake serve
with optional +version if there's a workspace override in effect. - If
lake env lean --server
fails fall back onlean --server
.
from vscode-lean4.
I don't think it makes sense to fall back to lake env lean --server
, just lake serve
and lean --server
should be good enough. Otherwise the logic looks good.
from vscode-lean4.
Yep, Mac showed me the "--" command line trick, so I already changed the code to use "lake serve -- filename" and "lake +version serve -- filename". I updated the PR description to match.
from vscode-lean4.
This PR is now merged
from vscode-lean4.
Related Issues (20)
- The "Install Lean" button mentions Elan, but users may not know what this is HOT 3
- Illegible colors in infoview on selection
- Autocomplete not working, vscode falls back to the default. HOT 2
- server out of sync with file when editing imports on Windows
- HTML-ish content in docstrings causes incorrect highlighting after them HOT 2
- Regular "Error: Unable to replace abbreviation" on unicode replacement over ssh HOT 1
- RFC: jump to definition in context menu in infoview HOT 2
- RFC: deselect all in info view
- Extension does not respect elan override when first started HOT 1
- Feature request: Support Live Share HOT 2
- Restore `fullRange` handling HOT 1
- Failed to start lsp on leanprover/lean4 HOT 1
- feature request: "go to next problem" should work on errors in imported files HOT 1
- feature request: in VSCode, open downstream files with errors
- Copy/pasting goal in Infoview collapses spacing between hypothesis names HOT 1
- Support `${workspaceFolder}` and similar variables in `lean4.toolchainPath` HOT 9
- [Mouseover pop-up] show type above error HOT 1
- Querying Lean Status Information from Terminal HOT 1
- Keyboard shortcut \<- for `←` not working HOT 2
- RFC: GUI button to download cache for a specific file HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vscode-lean4.