Coder Social home page Coder Social logo

Comments (6)

gebner avatar gebner commented on May 28, 2024

See also discussion on zulip: https://leanprover.zulipchat.com/#narrow/stream/147302-lean4-dev/topic/Expose.20--load-dynlib.20to.20Lean.3F/near/264029782

from vscode-lean4.

lovettchris avatar lovettchris commented on May 28, 2024

From Gabriel: On a high level, the biggest question is how the fallback should work. That is, when do we try lean --server after lake serve fails? Do we just call lake serve if there is a lakefile.lean present?

There's also a lot of tiny annoyances left. The extension has a configuration for the lean executable. Do we add one for lake as well? There is some version selection code by Chris which also makes it a bit harder to change replace lean --server by lake serve.

From Sebastian: Can we replace this with a setting for the toolchain root path (keeping bin/lean as the sanity check)? I'd like to avoid tying this to elan if not necessary.

from vscode-lean4.

lovettchris avatar lovettchris commented on May 28, 2024

Proposal, replace the following setting:
image

With:
image

Then the rules for using lake serve would be:

  1. is 'lake' or 'lake.exe' found in the toolchainPath, If not don't use lake
  2. is there a lakefile.lean in the current workspace root? If not don't use lake
  3. If the above are both good, use lake serve with optional +version if there's a workspace override in effect.
  4. If lake env lean --server fails fall back on lean --server.

from vscode-lean4.

gebner avatar gebner commented on May 28, 2024

I don't think it makes sense to fall back to lake env lean --server, just lake serve and lean --server should be good enough. Otherwise the logic looks good.

from vscode-lean4.

lovettchris avatar lovettchris commented on May 28, 2024

Yep, Mac showed me the "--" command line trick, so I already changed the code to use "lake serve -- filename" and "lake +version serve -- filename". I updated the PR description to match.

from vscode-lean4.

lovettchris avatar lovettchris commented on May 28, 2024

This PR is now merged

from vscode-lean4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.