Markers popups only work once spiderfied about leaflet.markercluster

[mourner]

Not only that but popups for unspiderfied markers open in wrong places. Obviously something broke popups for markers in recent commits, it was working perfectly before.

[pvhee]

Can confirm that the popups are broken, and seemingly in a random way. Using Leaflet v0.4.1, released today.

[danzel]

Yeah it was me.

Previously we were overwriting the latlng of each marker in the spiderfier and then restoring it when unspiderfying.
This could cause issues if you looked at the latlng of a marker while spiderfied, it would have its spiderfied latlng, not its actual latlng.
This change makes the popups appear in the wrong place as they are placed at the latlng of the point.

I'll take a look and see if there is a better solution, but I'll probably just revert this part back to the old latlng overwriting behaviour. (We back it up and restore the actual latlng when unspiderfying)

[danzel]

doing a bit more investigation here, looks like there is a few issues:

Marker popups appear in the wrong place - this is due to the latlng change, I think I'll change this back to before.

Popups stop working - Investigating why this happens now:
var m = markers._topClusterLevel.getAllChildMarkers(); var x = 0; for (var i =0 ;i < 388; i++) { if (m[i]._popup) x++; } console.log(x);

If you zoom down so markers appear standalone they lose their _popup, might be a leaflet bug from being added/removed from the map multiple times, investigating.

[danzel]

PR sent to fix the main issue of popups not working. :)

[danzel]

And 1be9202 should fix the popup positioning.
Thanks for the report :-)

[danzel]

Reopening as @blowsie says the fix doesn't work (https://github.com/CloudMade/Leaflet/pull/861)
I cannot reproduce this locally so far.

The example on http://danzel.github.com/Leaflet.markercluster/example/marker-clustering-realworld.10000.html works perfectly for me at the moment. (Safari on mac)

[pvhee]

Can confirm the fix does not work either, and tested in Chrome / Firefox on Mac.

[mourner]

Broken for me on Chrome 21 stable unfortunately, both issues (incorrect popup positioning and non-working popups for individual markers)

[danzel]

You guys are kidding me right? :P
Try a force refresh. I'll go download chrome for mac!

[mourner]

Hmm, something weird happening for sure... It reproduced for me even after force refresh, but after several more refreshes it started working well again.

[pvhee]

I did several force-refresh but the issue still remains and seems rather random. Initially popups will open fine, but when I start clicking/zooming around they stop working. Can confirm this issue on Safari,Chrome and FF on Mac.

On 1 Aug 2012, at 11:02, Vladimir Agafonkin wrote:

Hmm, something weird happening for sure... It reproduced for me even after force refresh, but after several more refreshes it started working well again.

---

Reply to this email directly or view it on GitHub:
https://github.com/danzel/Leaflet.markercluster/issues/24#issuecomment-7421961

[mourner]

Tried clicking/zooming around a lot but still couldn't reproduce.

Another unrelated thing that's driving me crazy for some reason is that in your examples, when clicking on the individual markers in Chrome, the drag cursor often appears even if you don't move the mouse, while on non-clustered Leaflet examples it doesn't work like that. Minor thing I know, but worth looking at too.

[danzel]

The issue previously occurred when a marker had been added to the map as an individual, either by zooming down until it unclustered or by clicking a cluster and having it spiderfy.
When it was removed from the map the popup would be removed too, so when it was readded the popup wouldn't be there.
Try clear your cache, my fresh install of chrome doesn't show the issue (that I can reproduce at least).
Will add an issue and investigate that one tomorrow mourner :)

[danzel]

If it still reproduces after a cache clear and a force refresh then post some direct instructions and i'll try reproduce it tomorrow, otherwise I'm pretty confident this is fixed. Thanks for the help guys :)