Coder Social home page Coder Social logo

Comments (12)

jacobtoye avatar jacobtoye commented on June 13, 2024

Yeah it totally would be. I've thought about this before but haven't got around to implementing it. Just need to add the handler to the polyline/polygon draw handler.

Feel free to submit a pull request, otherwise I'll look into it after the Christmas break.

from leaflet.draw.

ekaitzht avatar ekaitzht commented on June 13, 2024

I have tried to do in my project but I don´t know how to differ between 'click' and 'dblclick'. This issue is in https://github.com/CloudMade/Leaflet/issues/108

from leaflet.draw.

ekaitzht avatar ekaitzht commented on June 13, 2024

@jacobtoye I have implemented the 'dblclick' but I think that is not very good code, I am very newbie developing. Do you want that I send to you my code?

from leaflet.draw.

jacobtoye avatar jacobtoye commented on June 13, 2024

@ekaitzht we were all newbie devs at one stage, it's great that you are taking the initiative and working in open source :)

You can always commit your code the your Leaflet.draw repo (make a brach first). I can then check it out for you.

from leaflet.draw.

ekaitzht avatar ekaitzht commented on June 13, 2024

@jacobtoye first I am going to read something about branches I hope to commit the code soon.

from leaflet.draw.

ekaitzht avatar ekaitzht commented on June 13, 2024

@jacobtoye I am going to read something about branches and how it works that in github, I hope to send the code soon.

from leaflet.draw.

ekaitzht avatar ekaitzht commented on June 13, 2024

@jacobtoye I haved put a dblclick functionaly, reply me if you want to modify code.

from leaflet.draw.

ekaitzht avatar ekaitzht commented on June 13, 2024

@jacobtoye the problem is that we have to add a event to the same element. In JavaScript doesn´t know to differ when 'dblclick' and 'click' is in the same element.

from leaflet.draw.

ekaitzht avatar ekaitzht commented on June 13, 2024

any news about my problem :(

from leaflet.draw.

jacobtoye avatar jacobtoye commented on June 13, 2024

I see the issue (distinguishing the click and double click), however I don't think it is quite a high priority issue at the moment. The tooltip tells the user to close the shape by clicking the first point.

Right now I am working on the 0.2 branch when I get any spare time. I left this issue open to come back to it at a later date.

from leaflet.draw.

ekaitzht avatar ekaitzht commented on June 13, 2024

@jacobtoye thank you, I would like to help but I don't know how to implement using the dblclick marker event. issue #56

from leaflet.draw.

jacobtoye avatar jacobtoye commented on June 13, 2024

That's fine, I don't think this functionality is super important yet.

The issue with you pull was that you edited the built js files (in the /dist folder). What you want to do is edit the relevant files in the /src directory. When the build script is run it concatenates and minifies the files in the /src directory.

If you absolutely need this functionality I would suggest you create a branch for it in your fork. Make the changes to the relevant files in /src. Then pull any changes to Leaflet.draw to your branch when they are made.

from leaflet.draw.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.