Comments (14)
Works like a charm now! Thank you!
from jsonp-test-suite.
Hello @toddobryan
Would you please tell me which test class are you trying?
from jsonp-test-suite.
Now I identified the error location.
from jsonp-test-suite.
Sorry about that. I wasn't sure the right way to fix it or I would have given it a try.
from jsonp-test-suite.
It's OK. I will fix the problem in a few days.
Thank you for trying this test suite.
from jsonp-test-suite.
HI @toddobryan
I fixed the problem. Could you please test your implementation with the current master snapshot?
<dependency>
<groupId>org.leadpony</groupId>
<artifactId>jsonp-test-suite</artifactId>
<version>master-SNAPSHOT</version>
</dependency>
from jsonp-test-suite.
Will do. Thanks again! Also, this suite caught a mistake in Jackson Core for which I've submitted a pull request: FasterXML/jackson-core#557
I leaned heavily on your test structure, but had to change it a bit because of the difference in the way Jackson specifies locations. I may have borrowed enough of your code that they'd like you to provide a contributor license agreement, if you don't mind. If you do mind, I'll rework everything so that it doesn't depend on your code.
from jsonp-test-suite.
Hello @toddobryan
Thank you for your feedback.
I am glad hear it works properly for you.
I do not mind to accept the license agreement, but I think it is better for you that you rework or minimize the test cases copied. I am the author of a JSON parser, which is one of JSON-P implementation, therefore I may be a small competitor for Jackson's team.
from jsonp-test-suite.
Since the tests aren't distributed with the library, they were okay with them. Here's the commit...if there's anything in there that you would like me to remove, let me know.
https://github.com/FasterXML/jackson-core/pull/557/files
from jsonp-test-suite.
The reason this even exists is that I was working on a JSON-P implementation based on Jackson, so your tests caught problems in Jackson that I had converted to JSON-P.
I've reached the point where a lot of the Jackson conversion is done, but there's still a lot of JSON-P to implement--all of the Patch, Pointer, etc., stuff that really seems like, once you've converted from another representation into the javax.json
structures, you could just use a generic implementation of those.
I was thinking of using Joy for that, but wanted to make sure that you don't object. The idea would be that I'd implement JsonValue
and its subclasses based on Jackson and then defer to the Joy implementations of things like JsonPointer
, JsonPatch
, etc. But that's using an awful lot of your code to let people use another parser library, so I wanted to ask you first.
from jsonp-test-suite.
I was thinking of using Joy for that, but wanted to make sure that you don't object. The idea would be that I'd implement JsonValue and its subclasses based on Jackson and then defer to the Joy implementations of things like JsonPointer, JsonPatch, etc. But that's using an awful lot of your code to let people use another parser library, so I wanted to ask you first.
No I don't object to it.
Joy is licensed under Apache License 2.0, so you can freely use it if and only if the license conditions are fully met. For example, you copied the files in this repository but your repository seems to lack NOTICE file, which may be considered as a license violation. Please see 4. Redistribution. d in the Apache License 2.0.
If you need further discussion in regards to Joy, please create a new issue at Joy.
Thank you.
from jsonp-test-suite.
Major apologies. I should not have posted those files. I just copied them because I was too lazy to figure out how to run the tests by depending on the jar and don't intend them to be part of the final repo. I'm traveling this weekend, but as soon as I get home, I'll create a new repo without the file, and will add a README with a big thank you for the test suite. Also, if you'd prefer I not use issue comments for communication, my email is [email protected] and I'd be happy to use email instead.
from jsonp-test-suite.
@toddobryan
Do not worry about it. It is a trivial mistake anyone does.
from jsonp-test-suite.
I close this issue because the bug is fixed in the latest release 1.4.0. Please see also the changelog.
Thank you.
from jsonp-test-suite.
Related Issues (12)
- JsonExclusiveBadTerminationTestCase and EOF behaviour, expect exception? HOT 2
- The JsonPointer tests should expect the target to be modified HOT 3
- Two possible outputs for Double?
- JsonPointer syntax errors should not be valid HOT 11
- getConfigInUseShouldNotContainUnknownProperty checks that config properties are removed, but shouldn't HOT 1
- String comparisons should normalize to ASCII HOT 10
- Change object output comparisons to be order-insensitive HOT 3
- G_CLEF string should escape the slashes HOT 2
- thrown.getMessage() should first check if thrown is null HOT 2
- I wish the failing tests used zero-based indexes HOT 1
- Empty JSON should cause an exception, according to the grammar HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jsonp-test-suite.