Comments (9)
We should figure out what we want to do about certificates here.
Original comment by [email protected]
on 3 Oct 2006 at 6:52
from google-breakpad.
This patch is better ;-)
What do you mean about certificates? I admit I don't know much about the Windows
networking layer; are we worried that it would submit data even if the
certificate
were invalid?
Original comment by [email protected]
on 3 Oct 2006 at 7:38
Attachments:
from google-breakpad.
Yes, exactly: certificate validation.
Original comment by [email protected]
on 3 Oct 2006 at 8:46
from google-breakpad.
Original comment by [email protected]
on 16 Oct 2006 at 10:20
- Added labels: Milestone-Release1.0
from google-breakpad.
Original comment by [email protected]
on 18 Oct 2006 at 1:44
- Added labels: Component-Client-Sender, OpSys-Windows
from google-breakpad.
All we need to do is pass INTERNET_FLAG_SECURE in the flags argument of
HttpOpenRequest when the scheme is https.
For certificate verification, wininet will at least verify that the server
certificate's CN matches the hostname and that the date range is valid (bypass
with
INTERNET_FLAG_IGNORE_CERT_CN_INVALID and
INTERNET_FLAG_IGNORE_CERT_DATE_INVALID).
I'm not sure if it validates the certificate's trustworthiness or if that's
something
else we'd need to do ourselves.
Original comment by [email protected]
on 18 Oct 2006 at 9:33
from google-breakpad.
I've verified that comment 6 contains all that we need to do. If we follow
those
guidelines and attempt to hit a server with SSL/TLS, and it doesn't have a
trusted
certificate, HttpSendRequest will fail and GetLastError() will return
ERROR_INTERNET_INVALID_CA.
Original comment by [email protected]
on 19 Oct 2006 at 8:00
from google-breakpad.
This allows HTTPUpload users to specify an https scheme in the URL. It also
fixes
the proxy thing (#46) and checks the HTTP status returned by the server (which
sort
of fixes part of #44). I've also made the file version optional, although a
warning
is printed when the version is missing, and the server's free to reject
versionless
uploads.
Original comment by [email protected]
on 19 Oct 2006 at 8:24
- Changed state: Accepted
Attachments:
from google-breakpad.
Checked in, revision [41] (for #41!)
Original comment by [email protected]
on 19 Oct 2006 at 9:49
- Changed state: Fixed
from google-breakpad.
Related Issues (20)
- OOP dump request should not be handled in wait thread on win32
- Export to Github
- Breakpad fails to create minidump on ARM when i use threads HOT 3
- microdump processor unable to process microdump due to whitespaces in input HOT 3
- some file are dos format in linux HOT 1
- Undefined reference to pthread_once (Linux) HOT 4
- dump_syms fails with segmentation fault when trying to create symbol file for Android .so file HOT 1
- Initializer list order does not match field declaration order in src/client/windows/crash_generation HOT 1
- Problems while launching make on MinGW HOT 3
- Problems while launching make on Cygwin64 HOT 1
- Handling old style signal() calls in Breakpad HOT 2
- compile error for pdb_source_line_writer.cc when compiled with Windows clang (clang-cl).
- sys/signal.h
- FAIL: src/processor/proc_maps_linux_unittest HOT 1
- Can PopSeccompStackFrame be removed from breakpad? HOT 2
- Windows x64 support
- update README for new dev workflow HOT 6
- ExploitabilityLinuxUtilsTest.DisassembleBytesTest can fail if you get unlucky and the temp filename ends with 0
- MSVC link error in minidump.obj ParseProcMaps HOT 7
- Add dump_syms to gitignore HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from google-breakpad.