Coder Social home page Coder Social logo

Comments (9)

Jeremy1026 avatar Jeremy1026 commented on August 21, 2024 1

My pull request handles non-Debian distros in this manner. If there isn't a valid match for a release in GitHub the button will link to /get instead of providing a direct download to the .deb. Tested with a CentOS user-agent string of Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111109 CentOS/3.6.24-3.el6.centos Firefox/47.0

from lbry.com.

FUNKePILLs avatar FUNKePILLs commented on August 21, 2024

On it.

from lbry.com.

kauffj avatar kauffj commented on August 21, 2024

@FUNKePILLs how is this coming?

from lbry.com.

Jeremy1026 avatar Jeremy1026 commented on August 21, 2024

Pull request submitted for this issue - #353

from lbry.com.

xorgy avatar xorgy commented on August 21, 2024

On the surface this looks like a good idea, but it should probably still be a separate page for Linux users. Ubuntu may have a majority, but it'll be misleading for users of other distributions if they click to download and it just gives them a deb.

from lbry.com.

kauffj avatar kauffj commented on August 21, 2024

That is a very good point @xorgy! Is there a browser-based way of detecting .deb packaging support? If not, I agree that we should send to the full page on Linux.

from lbry.com.

xorgy avatar xorgy commented on August 21, 2024

@kauffj It doesn't seem like there is any reliable way to detect that, so I think a redirect is necessary for now.

from lbry.com.

xorgy avatar xorgy commented on August 21, 2024

@Jeremy1026 Interesting that Firefox on CentOS has a special UA, this is my Chromium on ArchLinux:

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36

And Firefox on the same

Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0

from lbry.com.

Jeremy1026 avatar Jeremy1026 commented on August 21, 2024

I’ll pop them in as a test to see what happens, but I think that should work as expected.

from lbry.com.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.